From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] kvm: testsuite: silence warnings on x86_64 Date: Thu, 31 Jan 2008 12:45:47 +0200 Message-ID: <47A1A6DB.6080804@qumranet.com> References: <4798BB24.9080100@qumranet.com> <20080131102320.GA15355@tapir> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Bernhard Kaindl , kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Carlo Marcelo Arenas Belon Return-path: In-Reply-To: <20080131102320.GA15355@tapir> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Carlo Marcelo Arenas Belon wrote: [I forgot to reply to the this:] >>> --- kvm-60/user/test/x86/access.c >>> +++ kvm-60/user/test/x86/access.c 2008/01/24 15:14:16 >>> @@ -1,6 +1,7 @@ >>> >>> #include "smp.h" >>> #include "printf.h" >>> +#include "string.h" >>> >>> #define true 1 >>> #define false 0 >>> @@ -569,7 +570,7 @@ >>> int r; >>> >>> printf("starting test\n\n"); >>> - smp_init(ac_test_run); >>> + smp_init((void (*)(void))ac_test_run); >>> r = ac_test_run(); >>> return r ? 0 : 1; >>> } >>> >>> >> Better to add a wrapper that conforms to the expected signature, and >> makes sure the return value of ac_test_run() is not lost. >> > > this will require redefining smp_init as shown by : > > --- a/user/test/x86/lib/smp.h > +++ b/user/test/x86/lib/smp.h > @@ -5,7 +5,7 @@ struct spinlock { > int v; > }; > > -void smp_init(void (*smp_main)(void)); > +void smp_init(int (*smp_main)(void)); > > int cpu_count(void); > int smp_id(void); > > and will require also fixing the smp.flat test to build againg and to return > a bool when executed (will send patches for doing both later if that is what > you want) > Yes please. smp.flat was only used during smp bringup, but it may be useful later. > >> Haven't run access.flat on smp for a long while; the results should be >> interesting after the page fault scaling work. >> > > if you meant `kvmctl -s2` it doesn't seem to get pass the kvm device > initialization inside kvmctl for kvm-60. > Sigh, we should start automated runs of this thing. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/