From: Anthony Liguori <aliguori-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
To: Paul Brook <paul-qD8j1LwMmJjtCj0u4l0SBw@public.gmane.org>
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
qemu-devel-qX2TKyscuCcdnm+yROfE0A@public.gmane.org,
Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>,
Fabrice Bellard <fabrice-+Yn2HnRVxb5AfugRpC6u6w@public.gmane.org>
Subject: Re: [PATCH 4/6] Tell BIOS about the number of CPUs
Date: Thu, 31 Jan 2008 18:28:00 -0600 [thread overview]
Message-ID: <47A26790.6010609@us.ibm.com> (raw)
In-Reply-To: <200802010014.07960.paul-qD8j1LwMmJjtCj0u4l0SBw@public.gmane.org>
Paul Brook wrote:
>> - cmos_init(ram_size, above_4g_mem_size, boot_device, hd);
>> + cmos_init(ram_size, above_4g_mem_size, boot_device, hd, smp_cpus);
>>
>
> smp_cpus is a global variable. Why bother passing it around?
>
True, I'll update the patch
> Are the CMOS contents documented anywhere?
>
No, but if you have a suggestion of where to document them, I'll add
documentation.
Regards,
Anthony Liguori
> Paul
>
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
next prev parent reply other threads:[~2008-02-01 0:28 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-31 22:36 [PATCH 0/6] Support for the Kernel Virtual Machine interface Anthony Liguori
[not found] ` <1201818980-27534-1-git-send-email-aliguori-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2008-01-31 22:36 ` [PATCH 1/6] Use correct types to enable > 2G support Anthony Liguori
[not found] ` <1201818980-27534-2-git-send-email-aliguori-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2008-01-31 23:54 ` Paul Brook
[not found] ` <200801312354.24382.paul-qD8j1LwMmJjtCj0u4l0SBw@public.gmane.org>
2008-02-01 0:25 ` Anthony Liguori
[not found] ` <47A26714.4000204-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2008-02-01 0:37 ` Paul Brook
[not found] ` <200802010037.30731.paul-qD8j1LwMmJjtCj0u4l0SBw@public.gmane.org>
2008-02-01 0:40 ` Anthony Liguori
2008-02-01 10:26 ` Fabrice Bellard
[not found] ` <47A2F3C7.6060409-+Yn2HnRVxb5AfugRpC6u6w@public.gmane.org>
2008-02-01 14:35 ` Anthony Liguori
[not found] ` <47A32E40.3000204-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2008-02-01 15:13 ` Avi Kivity
[not found] ` <47A33721.4020600-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2008-02-01 15:33 ` Anthony Liguori
[not found] ` <47A33BC6.3060705-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2008-02-01 15:40 ` [Qemu-devel] " Ian Jackson
[not found] ` <18339.15712.411486.395238-msK/Ju9w1zmnROeE8kUsYhEHtJm+Wo+I@public.gmane.org>
2008-02-01 17:53 ` Anthony Liguori
[not found] ` <47A35C7E.8050309-rdkfGonbjUSkNkDKm+mE6A@public.gmane.org>
2008-02-01 17:57 ` Daniel P. Berrange
[not found] ` <20080201175750.GD22981-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2008-02-01 20:31 ` Anthony Liguori
2008-02-01 21:33 ` [kvm-devel] " Paul Brook
2008-02-01 16:00 ` Paul Brook
[not found] ` <200802011600.10877.paul-qD8j1LwMmJjtCj0u4l0SBw@public.gmane.org>
2008-02-01 16:21 ` Fabrice Bellard
[not found] ` <47A3471B.7030702-+Yn2HnRVxb5AfugRpC6u6w@public.gmane.org>
2008-02-05 11:34 ` [Qemu-devel] " Ian Jackson
2008-02-01 17:49 ` [kvm-devel] " Anthony Liguori
2008-02-03 8:58 ` Izik Eidus
2008-01-31 22:36 ` [PATCH 2/6] SCI fixes Anthony Liguori
2008-01-31 22:36 ` [PATCH 3/6] Fix daemonize options Anthony Liguori
2008-01-31 22:36 ` [PATCH 4/6] Tell BIOS about the number of CPUs Anthony Liguori
[not found] ` <1201818980-27534-5-git-send-email-aliguori-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2008-02-01 0:14 ` Paul Brook
[not found] ` <200802010014.07960.paul-qD8j1LwMmJjtCj0u4l0SBw@public.gmane.org>
2008-02-01 0:28 ` Anthony Liguori [this message]
[not found] ` <47A26790.6010609-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2008-02-01 0:40 ` Paul Brook
2008-01-31 22:36 ` [PATCH 5/6] Refactor option ROM loading Anthony Liguori
2008-01-31 22:36 ` [PATCH 6/6] QEMU support for the Kernel Virtual Machine interface Anthony Liguori
[not found] ` <1201818980-27534-7-git-send-email-aliguori-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2008-02-01 9:49 ` Fabrice Bellard
[not found] ` <47A2EB14.8030804-+Yn2HnRVxb5AfugRpC6u6w@public.gmane.org>
2008-02-01 14:18 ` Anthony Liguori
2008-01-31 22:53 ` [qemu-devel] [PATCH 0/6] Support " Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47A26790.6010609@us.ibm.com \
--to=aliguori-r/jw6+rmf7hqt0dzr+alfa@public.gmane.org \
--cc=avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org \
--cc=fabrice-+Yn2HnRVxb5AfugRpC6u6w@public.gmane.org \
--cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=paul-qD8j1LwMmJjtCj0u4l0SBw@public.gmane.org \
--cc=qemu-devel-qX2TKyscuCcdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox