From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [PATCH 1/6] Use correct types to enable > 2G support Date: Thu, 31 Jan 2008 18:40:21 -0600 Message-ID: <47A26A75.5000900@us.ibm.com> References: <1201818980-27534-1-git-send-email-aliguori@us.ibm.com> <200801312354.24382.paul@codesourcery.com> <47A26714.4000204@us.ibm.com> <200802010037.30731.paul@codesourcery.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, qemu-devel-qX2TKyscuCcdnm+yROfE0A@public.gmane.org, Avi Kivity , Fabrice Bellard To: Paul Brook Return-path: In-Reply-To: <200802010037.30731.paul-qD8j1LwMmJjtCj0u4l0SBw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Paul Brook wrote: >>>> +#define PHYS_RAM_MAX_SIZE (2047 * 1024 * 1024 * 1024ULL) >>>> >>> This seems fairly arbitrary. Why? Any limit is certainly target specific. >>> >> On a 32-bit host, a 2GB limit is pretty reasonable since you're limited >> in virtual address space. On a 64-bit host, there isn't this >> fundamental limit. If a target may have it's own limit but there is >> definitely a host imposed limit. >> >> 2047GBs is a somewhat arbitrary limit though for 64-bit hosts. If you >> have a more logical suggestion, I'll happily change it. >> > > Don't have a limit at all. > > The reason we have the current 31-bit limit is because qemu is/was known to > use a signed int do hold the size. With your code 64-bit hosts should be able > to handle anything atoi can parse. > > As mentioned on IRC, I also noticed that ram_save hasn't been updated. > Okay, I'll update both of these. Regards, Anthony Liguori > Paul > ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/