From: Anthony Liguori <anthony-rdkfGonbjUSkNkDKm+mE6A@public.gmane.org>
To: Anthony Liguori <aliguori-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
Paul Brook <paul-qD8j1LwMmJjtCj0u4l0SBw@public.gmane.org>,
qemu-devel-qX2TKyscuCcdnm+yROfE0A@public.gmane.org,
Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>,
Fabrice Bellard <fabrice-+Yn2HnRVxb5AfugRpC6u6w@public.gmane.org>
Subject: Re: [PATCH 1/6] Fix VMware VGA init call
Date: Fri, 01 Feb 2008 16:23:52 -0600 [thread overview]
Message-ID: <47A39BF8.2040602@codemonkey.ws> (raw)
In-Reply-To: <1201903921-1125-2-git-send-email-aliguori-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 794 bytes --]
And attached is v2 which updates both uses of ram_size instead of just
the one :-)
Regards,
Anthony Liguori
Anthony Liguori wrote:
> This was never corrected during the ram_alloc() conversion.
>
> Index: qemu/hw/pc.c
> ===================================================================
> --- qemu.orig/hw/pc.c 2008-02-01 10:01:47.000000000 -0600
> +++ qemu/hw/pc.c 2008-02-01 10:57:01.000000000 -0600
> @@ -869,7 +869,7 @@
> } else if (vmsvga_enabled) {
> if (pci_enabled)
> pci_vmsvga_init(pci_bus, ds, phys_ram_base + ram_size,
> - ram_size, vga_ram_size);
> + vga_ram_addr, vga_ram_size);
> else
> fprintf(stderr, "%s: vmware_vga: no PCI bus\n", __FUNCTION__);
> } else {
>
[-- Attachment #2: pci_vmsgva_init_fix.diff --]
[-- Type: text/x-patch, Size: 1060 bytes --]
Subject: [PATCH 1/6] Fix VMware VGA init call (v2)
Cc: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
Cc: Fabrice Bellard <fabrice-+Yn2HnRVxb5AfugRpC6u6w@public.gmane.org>
Cc: Paul Brook <paul-qD8j1LwMmJjtCj0u4l0SBw@public.gmane.org>
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
This was never corrected during the ram_alloc() conversion.
Since v1, we update both uses of ram_size.
Index: qemu/hw/pc.c
===================================================================
--- qemu.orig/hw/pc.c 2008-02-01 16:21:40.000000000 -0600
+++ qemu/hw/pc.c 2008-02-01 16:22:04.000000000 -0600
@@ -868,8 +868,8 @@
}
} else if (vmsvga_enabled) {
if (pci_enabled)
- pci_vmsvga_init(pci_bus, ds, phys_ram_base + ram_size,
- ram_size, vga_ram_size);
+ pci_vmsvga_init(pci_bus, ds, phys_ram_base + vga_ram_size,
+ vga_ram_addr, vga_ram_size);
else
fprintf(stderr, "%s: vmware_vga: no PCI bus\n", __FUNCTION__);
} else {
[-- Attachment #3: Type: text/plain, Size: 228 bytes --]
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
[-- Attachment #4: Type: text/plain, Size: 186 bytes --]
_______________________________________________
kvm-devel mailing list
kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/kvm-devel
next prev parent reply other threads:[~2008-02-01 22:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-01 22:11 [PATCH 0/6] Support for the Kernel Virtual Machine interface (v2) Anthony Liguori
[not found] ` <1201903921-1125-1-git-send-email-aliguori-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2008-02-01 22:11 ` [PATCH 1/6] Fix VMware VGA init call Anthony Liguori
[not found] ` <1201903921-1125-2-git-send-email-aliguori-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2008-02-01 22:23 ` Anthony Liguori [this message]
2008-02-01 22:11 ` [PATCH 2/6] Use correct types to enable > 2G support (v2) Anthony Liguori
[not found] ` <1201903921-1125-3-git-send-email-aliguori-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2008-02-04 1:56 ` Anthony Liguori
[not found] ` <47A670B4.6020803-rdkfGonbjUSkNkDKm+mE6A@public.gmane.org>
2008-02-04 8:45 ` Izik Eidus
[not found] ` <1202114748.30861.6.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2008-02-04 15:31 ` Anthony Liguori
2008-02-10 10:48 ` Avi Kivity
2008-02-10 14:12 ` [Qemu-devel] " Paul Brook
2008-02-10 14:55 ` Avi Kivity
2008-02-10 14:59 ` Paul Brook
2008-02-10 15:14 ` Avi Kivity
2008-02-01 22:11 ` [PATCH 3/6] SCI fixes (v2) Anthony Liguori
2008-02-01 22:12 ` [PATCH 5/6] Tell BIOS about the number of CPUs (v2) Anthony Liguori
2008-02-01 22:12 ` [PATCH 6/6] QEMU support for the Kernel Virtual Machine interface (v2) Anthony Liguori
[not found] ` <1201903921-1125-7-git-send-email-aliguori-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2008-02-04 13:51 ` [Qemu-devel] " Soren Hansen
[not found] ` <20080204135149.GD4554-w/BXfMF2+jKSwEwcaNC2fFpr/1R2p/CL@public.gmane.org>
2008-02-04 15:14 ` Anthony Liguori
2008-02-01 22:11 ` [PATCH 4/6] Fix daemonize options (v2) Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47A39BF8.2040602@codemonkey.ws \
--to=anthony-rdkfgonbjusknkdkm+me6a@public.gmane.org \
--cc=aliguori-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
--cc=avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org \
--cc=fabrice-+Yn2HnRVxb5AfugRpC6u6w@public.gmane.org \
--cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=paul-qD8j1LwMmJjtCj0u4l0SBw@public.gmane.org \
--cc=qemu-devel-qX2TKyscuCcdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox