From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [PATCH 1/6] Fix VMware VGA init call Date: Fri, 01 Feb 2008 16:23:52 -0600 Message-ID: <47A39BF8.2040602@codemonkey.ws> References: <1201903921-1125-1-git-send-email-aliguori@us.ibm.com> <1201903921-1125-2-git-send-email-aliguori@us.ibm.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------070400080704010702070002" Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Paul Brook , qemu-devel-qX2TKyscuCcdnm+yROfE0A@public.gmane.org, Avi Kivity , Fabrice Bellard To: Anthony Liguori Return-path: In-Reply-To: <1201903921-1125-2-git-send-email-aliguori-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org This is a multi-part message in MIME format. --------------070400080704010702070002 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit And attached is v2 which updates both uses of ram_size instead of just the one :-) Regards, Anthony Liguori Anthony Liguori wrote: > This was never corrected during the ram_alloc() conversion. > > Index: qemu/hw/pc.c > =================================================================== > --- qemu.orig/hw/pc.c 2008-02-01 10:01:47.000000000 -0600 > +++ qemu/hw/pc.c 2008-02-01 10:57:01.000000000 -0600 > @@ -869,7 +869,7 @@ > } else if (vmsvga_enabled) { > if (pci_enabled) > pci_vmsvga_init(pci_bus, ds, phys_ram_base + ram_size, > - ram_size, vga_ram_size); > + vga_ram_addr, vga_ram_size); > else > fprintf(stderr, "%s: vmware_vga: no PCI bus\n", __FUNCTION__); > } else { > --------------070400080704010702070002 Content-Type: text/x-patch; name="pci_vmsgva_init_fix.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="pci_vmsgva_init_fix.diff" Subject: [PATCH 1/6] Fix VMware VGA init call (v2) Cc: Avi Kivity Cc: Fabrice Bellard Cc: Paul Brook Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org This was never corrected during the ram_alloc() conversion. Since v1, we update both uses of ram_size. Index: qemu/hw/pc.c =================================================================== --- qemu.orig/hw/pc.c 2008-02-01 16:21:40.000000000 -0600 +++ qemu/hw/pc.c 2008-02-01 16:22:04.000000000 -0600 @@ -868,8 +868,8 @@ } } else if (vmsvga_enabled) { if (pci_enabled) - pci_vmsvga_init(pci_bus, ds, phys_ram_base + ram_size, - ram_size, vga_ram_size); + pci_vmsvga_init(pci_bus, ds, phys_ram_base + vga_ram_size, + vga_ram_addr, vga_ram_size); else fprintf(stderr, "%s: vmware_vga: no PCI bus\n", __FUNCTION__); } else { --------------070400080704010702070002 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ --------------070400080704010702070002 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kvm-devel mailing list kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org https://lists.sourceforge.net/lists/listinfo/kvm-devel --------------070400080704010702070002--