From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [PATCH 2/6] Use correct types to enable > 2G support (v2) Date: Mon, 04 Feb 2008 09:31:37 -0600 Message-ID: <47A72FD9.90606@codemonkey.ws> References: <1201903921-1125-1-git-send-email-aliguori@us.ibm.com> <1201903921-1125-3-git-send-email-aliguori@us.ibm.com> <47A670B4.6020803@codemonkey.ws> <1202114748.30861.6.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Paul Brook , qemu-devel-qX2TKyscuCcdnm+yROfE0A@public.gmane.org, Avi Kivity , Fabrice Bellard To: Izik Eidus Return-path: In-Reply-To: <1202114748.30861.6.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Izik Eidus wrote: >> Do you recall what this change fixed? As Paul pointed out in IRC, using >> the host type here doesn't really fix the problem (target_ulong would be >> more appropriate). However, we're both curious what problem it's >> actually fixing since sign extending the int should just work. >> > > ok the commit say: > > kvm: qemu: change the type of the various page masks to unsigned long > > prevents truncation with >=4GB of guest physical memory > > > as far as i remember it was used to address something with > cpu_physical_memory_rw() probably related to &TARGET_PAGE_SIZE > or ~TARGET_PAGE_SIZE, > > the fact is that i dont know if it ever fixed anything > Thanks, that was my suspicion too. Regards, Anthony Liguori ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/