From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Otte Subject: Re: [PATCH 3 of 3] [POWERPC] Implement an ioctl that creates a vcpu of a particular type Date: Tue, 05 Feb 2008 14:41:40 +0100 Message-ID: <47A86794.4020408@de.ibm.com> References: <47A85C09.5070609@linux.vnet.ibm.com> Reply-To: carsteno-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, kvm-ppc-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Avi Kivity , Hollis Blanchard To: Christian Ehrhardt Return-path: In-Reply-To: <47A85C09.5070609-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Christian Ehrhardt wrote: > This should work for other architectures too. While we need to specify > cpu cores here others might specify something completely different with > the same interface. > So kvm_vcpu_create_type might be misleading while something like > kvm_vcpu_create_info might be more generic. > Just to get some background - do anyone else see the need to specify a > detail on vcpu_create for their implementation in future ? We do. For now, kvm_create_vcpu does create a cpu from a template. However our hardware control block allows to enable/disable various features. I would imagine that future userspace may want something different than the stock default values, and therefore a parameter would make sense for us too. ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/