From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [PATCH 0 of 3] RFC: creating a particular vcpu type Date: Tue, 05 Feb 2008 13:32:20 -0600 Message-ID: <47A8B9C4.3010709@us.ibm.com> References: <47A89285.40802@us.ibm.com> <1202234014.26953.25.camel@basalt> <47A8A582.5060502@us.ibm.com> <1202239399.26953.42.camel@basalt> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, kvm-ppc-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Avi Kivity To: Hollis Blanchard Return-path: In-Reply-To: <1202239399.26953.42.camel@basalt> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Hollis Blanchard wrote: >> If anything, I would think it would be better to expand the existing >> common-ioctl with the notion and then have a >> per-architecture hook within that ioctl. >> > > I *am* expanding the common ioctl. I am also preserving the existing > ABI: CREATE_VCPU still works, and CREATE_VCPU_TYPE is the new ioctl. And > then, voila, we have an architecture-specific hook: > kvm_arch_vcpu_create(). > > I will happily move the KVM_CREATE_VCPU_TYPE case from > kvm_arch_vm_ioctl() to kvm_vm_ioctl(), and since the additional > parameter is necessarily architecture-specific, it will simply call > kvm_arch_vcpu_create_type(). > So the new ioctl() has the extra data and the old ioctl() is just a compat interface which calls the new ioctl with a NULL extra data. I think this is the better approach if you're going this route. However, I still don't think that supporting asymmetric cores is really useful at the moment and that introducing a per-vm arch ioctl would be the best approach. Regards, Anthony Liguori ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/