From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: Fwd: [PATCH] boot a linux kernel from non-ide device Date: Fri, 08 Feb 2008 10:30:11 -0600 Message-ID: <47AC8393.6020906@codemonkey.ws> References: <5d6222a80802072305t2d536595q97d169df9dc00a48@mail.gmail.com> <5d6222a80802080742t3dfca5bs7894648af5d528a3@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel To: Glauber de Oliveira Costa Return-path: In-Reply-To: <5d6222a80802080742t3dfca5bs7894648af5d528a3-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org This patch seems reasonable to me. But FWIW, with extboot, it's possible to implement the -kernel option in a saner way. extboot already has code to take over int19 and load a kernel from memory on boot. It was based on the old -kernel support in QEMU (prior to hpa's rewrite) so it's not enabled at the moment. It should be pretty easy to update it though. This approach would allow -kernel to be used without any disk (which also solves your problem, but in a different way). We can also eliminate all the boot sector hijacking silliness. Regards, Anthony Liguori Glauber de Oliveira Costa wrote: > Reposting to kvm-devel, since aliguori notices that I'm relying on > non-upstream features of qemu > > ---------- Forwarded message ---------- > From: Glauber de Oliveira Costa > Date: Feb 8, 2008 5:05 AM > Subject: [PATCH] boot a linux kernel from non-ide device > To: qemu-devel-qX2TKyscuCcdnm+yROfE0A@public.gmane.org > > > Since it's now possible to use the -drive option, the test for something > in the index 0 of the IDE bus is too restrictive. > > A better idea, IMHO, is to check if the user specified any bootable device, > and only if not, fallback to the default, compatible behaviour of checking > hda regardless of the presence of a boot=on arg. > > -- > Glauber de Oliveira Costa. > "Free as in Freedom" > http://glommer.net > > "The less confident you are, the more serious you have to act." > > > > ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/