From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] Fix to kvm_arch_vcpu_ioctl_set_sregs so that set_cr0 works properly Date: Mon, 11 Feb 2008 10:11:20 +0200 Message-ID: <47B00328.7010906@qumranet.com> References: <1DF02D2D-98D0-4695-A4A5-724A12616142@transitive.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel@lists.sourceforge.net To: Paul Knowles Return-path: In-Reply-To: <1DF02D2D-98D0-4695-A4A5-724A12616142@transitive.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces@lists.sourceforge.net Errors-To: kvm-devel-bounces@lists.sourceforge.net List-Id: kvm.vger.kernel.org Paul Knowles wrote: > Whilst working on getting a VM to initialize in to IA32e mode I found > this issue. set_cr0 relies on comparing the old cr0 to the new one to > work correctly. > > Applied, thanks. I moved the assignment below rather than deleting it to be a little more conservative (svm_set_cr0 doesn't always actually set cr0 these days). > Whilst this fix gets me a little closer I still fail to run due to an > invalid VMX state. Has anybody else ever tried to set up a VM to jump > straight in to IA32e mode? > Sure. Initially kvm only did long mode, and these days when you live migrate (or save/restore) a long mode guest you are effectively starting the new instance in long mode. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/