From: Avi Kivity <avi@qumranet.com>
To: Andrea Arcangeli <andrea@qumranet.com>
Cc: kvm-devel@lists.sourceforge.net, Chris Lalancette <clalance@redhat.com>
Subject: Re: Broken external module build on 2.6.23
Date: Mon, 11 Feb 2008 14:24:18 +0200 [thread overview]
Message-ID: <47B03E72.9000206@qumranet.com> (raw)
In-Reply-To: <20080211111944.GG7051@v2.random>
Andrea Arcangeli wrote:
> I created a more complete patch below, this will solve all my silent
> time-wasting miscompilations (currnently when building kvm.git on a
> newer mainline kernels, certain kvm*.h $KERNELDIR headers are included
> instead of my modified ones in $LINUX, so the build can crash if
> $LINUX and $KERNELDIR don't have the kvm*.h headers in sync) and this
> below patch will retain compatibility with older kernels too. If patch
> doesn't wipe kernel/include you can follow it with a rm -r
> kernel/include. I verified libkvm already gives more priority to
> whatever is in kernel/include and only if kernel/include are missing
> it uses the kvm.h in /usr/include/linux/kvm.h (I filled all my
> /usr/src and /usr/include headers with #error "x" to be sure... along
> with running gcc -E and checking the cpp work).
>
>
Thanks, applied that. I added an include-compat/asm symlink so that it
builds.
Please turn on git rename detection for better readability with such
patches.
--
error compiling committee.c: too many arguments to function
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
next prev parent reply other threads:[~2008-02-11 12:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-04 21:01 Broken external module build on 2.6.23 Chris Lalancette
[not found] ` <47A77D2B.90902-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2008-02-05 23:15 ` Andrea Arcangeli
2008-02-11 8:14 ` Avi Kivity
2008-02-11 11:19 ` Andrea Arcangeli
2008-02-11 11:26 ` Andrea Arcangeli
2008-02-11 12:24 ` Avi Kivity [this message]
2008-02-11 12:24 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47B03E72.9000206@qumranet.com \
--to=avi@qumranet.com \
--cc=andrea@qumranet.com \
--cc=clalance@redhat.com \
--cc=kvm-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox