From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: Broken external module build on 2.6.23 Date: Mon, 11 Feb 2008 14:24:18 +0200 Message-ID: <47B03E72.9000206@qumranet.com> References: <47A77D2B.90902@redhat.com> <20080205231546.GH7441@v2.random> <47B00400.3010306@qumranet.com> <20080211111944.GG7051@v2.random> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel@lists.sourceforge.net, Chris Lalancette To: Andrea Arcangeli Return-path: In-Reply-To: <20080211111944.GG7051@v2.random> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces@lists.sourceforge.net Errors-To: kvm-devel-bounces@lists.sourceforge.net List-Id: kvm.vger.kernel.org Andrea Arcangeli wrote: > I created a more complete patch below, this will solve all my silent > time-wasting miscompilations (currnently when building kvm.git on a > newer mainline kernels, certain kvm*.h $KERNELDIR headers are included > instead of my modified ones in $LINUX, so the build can crash if > $LINUX and $KERNELDIR don't have the kvm*.h headers in sync) and this > below patch will retain compatibility with older kernels too. If patch > doesn't wipe kernel/include you can follow it with a rm -r > kernel/include. I verified libkvm already gives more priority to > whatever is in kernel/include and only if kernel/include are missing > it uses the kvm.h in /usr/include/linux/kvm.h (I filled all my > /usr/src and /usr/include headers with #error "x" to be sure... along > with running gcc -E and checking the cpp work). > > Thanks, applied that. I added an include-compat/asm symlink so that it builds. Please turn on git rename detection for better readability with such patches. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/