From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: preempt emulation miscompile fix Date: Tue, 12 Feb 2008 14:21:45 +0200 Message-ID: <47B18F59.7050305@qumranet.com> References: <20080212114616.GP7051@v2.random> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel@lists.sourceforge.net To: Andrea Arcangeli Return-path: In-Reply-To: <20080212114616.GP7051@v2.random> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces@lists.sourceforge.net Errors-To: kvm-devel-bounces@lists.sourceforge.net List-Id: kvm.vger.kernel.org Andrea Arcangeli wrote: > Hello, > > I tracked down the reason of my kernel crashing builds with the latest > kvm-userland package. It has taken a bit of time because with certain > workloads this wouldn't crash. I've been testing stuff with preempt > emulation enabled most of the time to be sure it worked (and to fix > the host breakpoint too). This will fix it by importing the task > struct before we define CONFIG_PREEMPT_NOTIFIERS. preempt.h is most > certainly unnecessary but it's a good rule of thumb to include > anything that uses CONFIG_PREEMPT_NOTIFIERS before defining it. > > Applied, thanks. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/