From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: SIMPLE_ATTRIBUTE_GETTER compile fix Date: Tue, 12 Feb 2008 14:26:12 +0200 Message-ID: <47B19064.40709@qumranet.com> References: <20080212115255.GQ7051@v2.random> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel@lists.sourceforge.net To: Andrea Arcangeli Return-path: In-Reply-To: <20080212115255.GQ7051@v2.random> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces@lists.sourceforge.net Errors-To: kvm-devel-bounces@lists.sourceforge.net List-Id: kvm.vger.kernel.org Andrea Arcangeli wrote: > Hello, > > this GETTER stuff looks a bit tricky... (we've just to cope with it). > > Anyway this allows building again and perhaps there's something good > in the patch (not sure about the >= 2.6.25 side that I didn't touch) > > Signed-off-by: Andrea Arcangeli > > diff --git a/kernel/external-module-compat.h b/kernel/external-module-compat.h > index 3b45999..fe6108c 100644 > --- a/kernel/external-module-compat.h > +++ b/kernel/external-module-compat.h > @@ -658,7 +664,7 @@ static inline struct page *__kvm_vm_fault(struct vm_area_struct *vma, > { \ > u64 ret = 0; \ > \ > - __##x(v, &ret); \ > + __##x(v); \ > return ret; \ > } > But, getters are defined as > static int vm_stat_get(void *_offset, u64 *val) Perhaps you have an old kvm.git? -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/