From mboxrd@z Thu Jan 1 00:00:00 1970 From: Izik Eidus Subject: [PATCH] fixing dirty bit setting for calls of rmap_write_protect Date: Tue, 12 Feb 2008 18:05:58 +0200 Message-ID: <47B1C3E6.3050906@qumranet.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------000205070800000306040602" To: kvm-devel , Avi Kivity Return-path: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces@lists.sourceforge.net Errors-To: kvm-devel-bounces@lists.sourceforge.net List-Id: kvm.vger.kernel.org This is a multi-part message in MIME format. --------------000205070800000306040602 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit -- woof. --------------000205070800000306040602 Content-Type: text/x-patch; name="0004-KVM-mmu-fixing-dirty-bit-setting-for-calls-of-rmap.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename*0="0004-KVM-mmu-fixing-dirty-bit-setting-for-calls-of-rmap.patc"; filename*1="h" >>From 8a849eb0cedacb384676aa7416e8997d89fe9b0f Mon Sep 17 00:00:00 2001 From: Izik Eidus Date: Tue, 12 Feb 2008 17:56:43 +0200 Subject: [PATCH] KVM: mmu: fixing dirty bit setting for calls of rmap_write_protect when mmu_set_spte is checking if a page related to spte should be release as dirty or clean, it check if the shadow pte was writeble, but in case rmap_write_protect get called it is possible for shadow ptes that were writeble to become readonly and therefor mmu_set_spte will release the pages of the sptes as clean and not as dirty. this patch fix this issue by marking the page as dirty inside rmap_write_protect Signed-off-by: Izik Eidus --- arch/x86/kvm/mmu.c | 8 +++++++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c index 635e70c..83136f2 100644 --- a/arch/x86/kvm/mmu.c +++ b/arch/x86/kvm/mmu.c @@ -520,8 +520,14 @@ static void rmap_write_protect(struct kvm *kvm, u64 gfn) } spte = rmap_next(kvm, rmapp, spte); } - if (write_protected) + if (write_protected) { + struct page *page; + + spte = rmap_next(kvm, rmapp, NULL); + page = pfn_to_page((*spte & PT64_BASE_ADDR_MASK) >> PAGE_SHIFT); + SetPageDirty(page); kvm_flush_remote_tlbs(kvm); + } } #ifdef MMU_DEBUG -- 1.5.3.6 --------------000205070800000306040602 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ --------------000205070800000306040602 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kvm-devel mailing list kvm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-devel --------------000205070800000306040602--