From mboxrd@z Thu Jan  1 00:00:00 1970
From: Anthony Liguori <anthony@codemonkey.ws>
Subject: Re: [RFC] Qemu powerpc work around
Date: Tue, 12 Feb 2008 18:47:59 -0600
Message-ID: <47B23E3F.3020401@codemonkey.ws>
References: <1202852254.16861.6.camel@thinkpad.austin.ibm.com>	
	<47B2133D.4090801@codemonkey.ws>	
	<1202853180.16861.10.camel@thinkpad.austin.ibm.com>	
	<47B217C0.5070905@codemonkey.ws>
	<1202856652.18969.6.camel@thinkpad.austin.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Cc: kvm-devel <kvm-devel@lists.sourceforge.net>,
	hollisb <hollisb@linux.vnet.ibm.com>
To: jyoung5@us.ibm.com
Return-path: <kvm-devel-bounces@lists.sourceforge.net>
In-Reply-To: <1202856652.18969.6.camel@thinkpad.austin.ibm.com>
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/kvm-devel>,
	<mailto:kvm-devel-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum_name=kvm-devel>
List-Post: <mailto:kvm-devel@lists.sourceforge.net>
List-Help: <mailto:kvm-devel-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/kvm-devel>,
	<mailto:kvm-devel-request@lists.sourceforge.net?subject=subscribe>
Sender: kvm-devel-bounces@lists.sourceforge.net
Errors-To: kvm-devel-bounces@lists.sourceforge.net
List-Id: kvm.vger.kernel.org

Jerone Young wrote:
> So here is another respin .. not so broken for everyone this time ;-)
>   

Just a few small comments...

>  ifeq ($(USE_KVM), 1)
>  LIBOBJS+=qemu-kvm.o
>  endif
> @@ -214,6 +222,7 @@ LIBOBJS+= op_helper.o helper.o
>  LIBOBJS+= op_helper.o helper.o
>  ifeq ($(USE_KVM), 1)
>  LIBOBJS+= qemu-kvm-powerpc.o
> +LIBOBJS+= fake-exec.o
>  endif
>  endif
>   

Could you move this out of the USE_KVM and PPC checks and simply put it 
in a ifeq ($(NO_TCG), 1) check?  Also, can you move the file into 
target-ppc?  This way, it will be much easier to implement something 
similar for ia64 and x86.

> diff --git a/qemu/fake-exec.c b/qemu/fake-exec.c
> new file mode 100644
> --- /dev/null
> +++ b/qemu/fake-exec.c
> @@ -0,0 +1,62 @@
>   

Please add a copyright to this file.

Regards,

Anthony Liguori


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/