Re: [patch 3/5] KVM: hypercall batching

[Avi Kivity <avi@qumranet.com>]

Hollis Blanchard wrote:
>> Kernel data is physically contiguous (true for per-cpu data as well?), 
>> so no there's issue here.
>>     
>
> So this is an addition to the ABI, that the data must be physically
> contiguous. That's a pretty subtle implicit requirement, and it's easy
> to resolve the issue by requiring page-aligned data in the guest in the
> first place.
>
> Please don't forget that there are other OSes that could use this
> interface as well...
>   

I think it's fairly straightforward that a (phys_addr, length) API 
implies physically contiguous memory.  If the guest doesn't have 
physically contiguous memory, it can page align itself.

But you do raise an important issue, that our ABIs (host/user and 
host/guest) are seriously underdocumented.


-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/