Re: Out-of-box kvm-61 driver crash, first kvm problem ever, boo hoo...

[Avi Kivity <avi@qumranet.com>]

[-- Attachment #1: Type: text/plain, Size: 513 bytes --]

Avi Kivity wrote:
> duck@sophos.com wrote:
>> EIP: [<f8b8dcd2>] vmx_set_efer+0xa2/0xb0 [kvm_intel] SS:ESP 
>> 0068:f4a63ed4
>>
>>   
>
> Not completely unexpected. You are running a Core (not 2) processor 
> which doesn't support nx or x86_64, so it doesn't have the EFER 
> register. kvm-61 adds support for the EFER on i386, but apparently 
> doesn't handle those old cpus well.
>
> I'll try to get a patch for you to test.
>

Attached.

-- 
Any sufficiently difficult bug is indistinguishable from a feature.


[-- Attachment #2: no-efer-on-old-core.patch --]
[-- Type: text/x-patch, Size: 411 bytes --]

diff --git a/kernel/vmx.c b/kernel/vmx.c
index e75b2f5..a575e54 100644
--- a/kernel/vmx.c
+++ b/kernel/vmx.c
@@ -1342,6 +1342,8 @@ static void vmx_set_efer(struct kvm_vcpu *vcpu, u64 efer)
 	struct kvm_msr_entry *msr = find_msr_entry(vmx, MSR_EFER);
 
 	vcpu->arch.shadow_efer = efer;
+	if (!msr)
+		return;
 	if (efer & EFER_LMA) {
 		vmcs_write32(VM_ENTRY_CONTROLS,
 				     vmcs_read32(VM_ENTRY_CONTROLS) |

[-- Attachment #3: Type: text/plain, Size: 228 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

[-- Attachment #4: Type: text/plain, Size: 158 bytes --]

_______________________________________________
kvm-devel mailing list
kvm-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-devel