From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: Out-of-box kvm-61 driver crash, first kvm problem ever, boo hoo... Date: Wed, 20 Feb 2008 11:42:12 +0200 Message-ID: <47BBF5F4.7050207@qumranet.com> References: <47BBF1D3.2020701@qumranet.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------090102040702090107060407" Cc: kvm-devel@lists.sourceforge.net To: duck@sophos.com Return-path: In-Reply-To: <47BBF1D3.2020701@qumranet.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces@lists.sourceforge.net Errors-To: kvm-devel-bounces@lists.sourceforge.net List-Id: kvm.vger.kernel.org This is a multi-part message in MIME format. --------------090102040702090107060407 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Avi Kivity wrote: > duck@sophos.com wrote: >> EIP: [] vmx_set_efer+0xa2/0xb0 [kvm_intel] SS:ESP >> 0068:f4a63ed4 >> >> > > Not completely unexpected. You are running a Core (not 2) processor > which doesn't support nx or x86_64, so it doesn't have the EFER > register. kvm-61 adds support for the EFER on i386, but apparently > doesn't handle those old cpus well. > > I'll try to get a patch for you to test. > Attached. -- Any sufficiently difficult bug is indistinguishable from a feature. --------------090102040702090107060407 Content-Type: text/x-patch; name="no-efer-on-old-core.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="no-efer-on-old-core.patch" diff --git a/kernel/vmx.c b/kernel/vmx.c index e75b2f5..a575e54 100644 --- a/kernel/vmx.c +++ b/kernel/vmx.c @@ -1342,6 +1342,8 @@ static void vmx_set_efer(struct kvm_vcpu *vcpu, u64 efer) struct kvm_msr_entry *msr = find_msr_entry(vmx, MSR_EFER); vcpu->arch.shadow_efer = efer; + if (!msr) + return; if (efer & EFER_LMA) { vmcs_write32(VM_ENTRY_CONTROLS, vmcs_read32(VM_ENTRY_CONTROLS) | --------------090102040702090107060407 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ --------------090102040702090107060407 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kvm-devel mailing list kvm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-devel --------------090102040702090107060407--