From: Avi Kivity <avi@qumranet.com>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: kvm-devel <kvm-devel@lists.sourceforge.net>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kvm: sparse fixes for kvm/x86.c
Date: Thu, 21 Feb 2008 11:02:38 +0200 [thread overview]
Message-ID: <47BD3E2E.3080009@qumranet.com> (raw)
In-Reply-To: <1203445550.10464.10.camel@brick>
Harvey Harrison wrote:
> In two case statements, use the ever popular 'i' instead of index:
> arch/x86/kvm/x86.c:1063:7: warning: symbol 'index' shadows an earlier one
> arch/x86/kvm/x86.c:1000:9: originally declared here
> arch/x86/kvm/x86.c:1079:7: warning: symbol 'index' shadows an earlier one
> arch/x86/kvm/x86.c:1000:9: originally declared here
>
> Missing semicolon.
> arch/x86/kvm/x86.c:493:3: warning: returning void-valued expression
>
> Make it static.
> arch/x86/kvm/x86.c:1945:24: warning: symbol 'emulate_ops' was not declared. Should it be static?
>
> Drop the return statements.
> arch/x86/kvm/x86.c:2878:2: warning: returning void-valued expression
> arch/x86/kvm/x86.c:2944:2: warning: returning void-valued expression
>
Applied all three patches, thanks.
--
error compiling committee.c: too many arguments to function
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
prev parent reply other threads:[~2008-02-21 9:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-19 18:25 [PATCH] kvm: sparse fixes for kvm/x86.c Harvey Harrison
2008-02-21 9:02 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47BD3E2E.3080009@qumranet.com \
--to=avi@qumranet.com \
--cc=harvey.harrison@gmail.com \
--cc=kvm-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox