From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@qumranet.com>
Subject: Re: [PATCH] kvm: sparse fixes for kvm/x86.c
Date: Thu, 21 Feb 2008 11:02:38 +0200
Message-ID: <47BD3E2E.3080009@qumranet.com>
References: <1203445550.10464.10.camel@brick>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Cc: kvm-devel <kvm-devel@lists.sourceforge.net>,
	LKML <linux-kernel@vger.kernel.org>
To: Harvey Harrison <harvey.harrison@gmail.com>
Return-path: <kvm-devel-bounces@lists.sourceforge.net>
In-Reply-To: <1203445550.10464.10.camel@brick>
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/kvm-devel>,
	<mailto:kvm-devel-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum_name=kvm-devel>
List-Post: <mailto:kvm-devel@lists.sourceforge.net>
List-Help: <mailto:kvm-devel-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/kvm-devel>,
	<mailto:kvm-devel-request@lists.sourceforge.net?subject=subscribe>
Sender: kvm-devel-bounces@lists.sourceforge.net
Errors-To: kvm-devel-bounces@lists.sourceforge.net
List-Id: kvm.vger.kernel.org

Harvey Harrison wrote:
> In two case statements, use the ever popular 'i' instead of index:
> arch/x86/kvm/x86.c:1063:7: warning: symbol 'index' shadows an earlier one
> arch/x86/kvm/x86.c:1000:9: originally declared here
> arch/x86/kvm/x86.c:1079:7: warning: symbol 'index' shadows an earlier one
> arch/x86/kvm/x86.c:1000:9: originally declared here
>
> Missing semicolon.
> arch/x86/kvm/x86.c:493:3: warning: returning void-valued expression
>
> Make it static.
> arch/x86/kvm/x86.c:1945:24: warning: symbol 'emulate_ops' was not declared. Should it be static?
>
> Drop the return statements.
> arch/x86/kvm/x86.c:2878:2: warning: returning void-valued expression
> arch/x86/kvm/x86.c:2944:2: warning: returning void-valued expression
>   

Applied all three patches, thanks.

-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/