From: Avi Kivity <avi@qumranet.com>
To: Alexander Graf <alex@csgraf.de>
Cc: kvm-devel <kvm-devel@lists.sourceforge.net>,
Bernhard Kaindl <bk@suse.de>
Subject: Re: [PATCH] Fix host_cpuid() in qemu/qemu-kvm-x86.c
Date: Thu, 21 Feb 2008 12:52:42 +0200 [thread overview]
Message-ID: <47BD57FA.3080306@qumranet.com> (raw)
In-Reply-To: <0FA4789B-2CC6-4801-B5CB-6EE8E4E136D3@csgraf.de>
Alexander Graf wrote:
>
> This version fixes a wrong identifier (%0 instead of %1) and makes
> things work without touching the stack. This works by using %esi as
> backup-register for %ebx. It furthermore moves "function" directly to
> eax, without relying on gcc optimizations to realize this.
>
Applied, thanks. Let's see if gcc can handle 4 register constraints + 1
clobber.
--
error compiling committee.c: too many arguments to function
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
prev parent reply other threads:[~2008-02-21 10:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-20 15:57 [PATCH] Fix host_cpuid() in qemu/qemu-kvm-x86.c Bernhard Kaindl
2008-02-21 8:46 ` Avi Kivity
2008-02-21 9:14 ` Alexander Graf
2008-02-21 10:34 ` Alexander Graf
2008-02-21 10:52 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47BD57FA.3080306@qumranet.com \
--to=avi@qumranet.com \
--cc=alex@csgraf.de \
--cc=bk@suse.de \
--cc=kvm-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox