From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [patch 2/5] KVM: hypercall based pte updates and TLB flushes (v2) Date: Thu, 21 Feb 2008 17:43:53 +0200 Message-ID: <47BD9C39.3060601@qumranet.com> References: <20080220194720.750258362@harmony.lab.boston.redhat.com> <20080220195019.634096711@harmony.lab.boston.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel@lists.sourceforge.net To: Marcelo Tosatti Return-path: In-Reply-To: <20080220195019.634096711@harmony.lab.boston.redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces@lists.sourceforge.net Errors-To: kvm-devel-bounces@lists.sourceforge.net List-Id: kvm.vger.kernel.org Marcelo Tosatti wrote: > Hypercall based pte updates are faster than faults, and also allow use > of the lazy MMU mode to batch operations. > > Don't report the feature if two dimensional paging is enabled. > > > +static int kvm_hypercall_mmu_write(struct kvm_vcpu *vcpu, gpa_t addr, > + unsigned long a1, unsigned long a2) > Putting this and the other mmu hypercalls in mmu.c will reduce namespace pollution (esp. as the names you expose don't have the kvm_ prefix). -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/