public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@qumranet.com>
To: Andreas Winkelbauer <andreas.winkelbauer@gmx.at>
Cc: kvm-devel@lists.sourceforge.net, Pelle@quicknet.nl,
	arne.brutschy@ulb.ac.be, lmann@nt.net
Subject: Re: [PATCH] fix screen corruption bug in vga_draw_graphic()
Date: Sun, 24 Feb 2008 09:05:55 +0200	[thread overview]
Message-ID: <47C11753.5000800@qumranet.com> (raw)
In-Reply-To: <47BF325B.8050101@gmx.at>

Andreas Winkelbauer wrote:
> hi,
>
> the attached patch fixes the screen corruption issues which were 
> reported by others, see:
>
> http://article.gmane.org/gmane.comp.emulators.kvm.devel/13543
> http://article.gmane.org/gmane.comp.emulators.kvm.devel/13409
>
> The bug is kvm specific and can only be observed in graphics mode 
> using relatively high resolutions (when one line uses more than one 
> page of memory). As far as I've seen this bug is around since commit 
> dd9591e0fea25a1414f4a6b2faa61ed733e0acc6 (5 nov 2006).
>
> I've attached two versions of the patch. One just changes the relevant 
> line and the other one also cleans up formatting (indention) of the 
> kvm specific code.

Applied the no-formatting version, thanks.  Please sign off on patches 
next time.

The way to apply formatting changes while fixing something is with a 
separate patch that does nothing but fix the formatting, either on top 
of the fix, or to be applied before the fix.  This way the fixing patch 
is kept small and easily understandable.


-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

  reply	other threads:[~2008-02-24  7:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-22 20:36 [PATCH] fix screen corruption bug in vga_draw_graphic() Andreas Winkelbauer
2008-02-24  7:05 ` Avi Kivity [this message]
2008-02-25  9:12 ` Arne Brutschy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47C11753.5000800@qumranet.com \
    --to=avi@qumranet.com \
    --cc=Pelle@quicknet.nl \
    --cc=andreas.winkelbauer@gmx.at \
    --cc=arne.brutschy@ulb.ac.be \
    --cc=kvm-devel@lists.sourceforge.net \
    --cc=lmann@nt.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox