From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] qemu: implicit precedence for logical operator in has_work Date: Sun, 24 Feb 2008 11:59:41 +0200 Message-ID: <47C1400D.2020103@qumranet.com> References: <20080220083042.GB28629@tapir> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel@lists.sourceforge.net, Carlo Marcelo Arenas Belon To: Alexander Graf Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces@lists.sourceforge.net Errors-To: kvm-devel-bounces@lists.sourceforge.net List-Id: kvm.vger.kernel.org Alexander Graf wrote: > On Feb 20, 2008, at 9:30 AM, Carlo Marcelo Arenas Belon wrote: > > >> janitorial fix for : >> >> qemu/qemu-kvm.c: In function `has_work': >> qemu/qemu-kvm.c:140: warning: suggest parentheses around && within || >> >> Signed-off-by: Carlo Marcelo Arenas Belon >> --- >> qemu/qemu-kvm.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/qemu/qemu-kvm.c b/qemu/qemu-kvm.c >> index ffc59d5..4056453 100644 >> --- a/qemu/qemu-kvm.c >> +++ b/qemu/qemu-kvm.c >> @@ -137,7 +137,7 @@ extern int vm_running; >> >> static int has_work(CPUState *env) >> { >> - if (!vm_running || env && vcpu_info[env->cpu_index].stopped) >> + if (!vm_running || (env && vcpu_info[env->cpu_index].stopped)) >> > > What exactly is the env check needed for here? > > This code arrived from another location, where it was necessary. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/