Re: [PATCH 1/3] Move common VGAState attributes to VGA_STATE_COMMON

[Avi Kivity <avi@qumranet.com>]

Anthony Liguori wrote:
> Avi Kivity wrote:
>   
>> The trick to passing through patches is to have a
>>
>> From: Original Author <email@example.com>
>>
>> line in the beginning, which git picks up and uses to maintain 
>> authorship information. Also, sign-off normally. Acked-by means "I know 
>> the author" while Reviewed-by means "I know the author well".
>>   
>>     
>
> Does From have to be the first line?  

Yes (but after the regular email headers).

> git-send-email never seems to do 
> anything with From for me.
>   

It's 'git am' which is the target of this.  When applying such a patch 
from email, it will set the author automatically.

The whole thing should work automatically, so if the patch has the 
correct authorship in your repo, it should come out fine without further 
effort.  Not sure if format-patch or send-email is responsible.

-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/