From mboxrd@z Thu Jan 1 00:00:00 1970 From: Glauber Costa Subject: Re: [PATCH 4/15] mark processors as presents Date: Mon, 25 Feb 2008 11:43:59 -0300 Message-ID: <47C2D42F.6060109@redhat.com> References: <1203716079-4872-1-git-send-email-gcosta@redhat.com> <1203716079-4872-2-git-send-email-gcosta@redhat.com> <1203716079-4872-3-git-send-email-gcosta@redhat.com> <1203716079-4872-4-git-send-email-gcosta@redhat.com> <1203716079-4872-5-git-send-email-gcosta@redhat.com> <47C13A05.5090607@qumranet.com> <47C2D2CB.6000803@redhat.com> <47C2D591.8030104@qumranet.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel@lists.sourceforge.net, marcelo@kvack.org, chrisw@sous-sol.org To: Avi Kivity Return-path: In-Reply-To: <47C2D591.8030104@qumranet.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces@lists.sourceforge.net Errors-To: kvm-devel-bounces@lists.sourceforge.net List-Id: kvm.vger.kernel.org Avi Kivity wrote: > Glauber Costa wrote: >>> >>> There is now code in rombios32.c to do this. It needs to be >>> removed. See acpi_build_processor_ssdt(). >> >> Building the table by hand is trivial in the case where the processors >> are just _listed_, and can be easily justified. This first patch just >> add the _STA method, but other follows, which turns the processor >> block into a quite complicated thing. Not to mention the operational >> region, >> the notifications that have to refer to the processor objects, etc. >> >> So I can't see any valid justification for using the code in >> rombios32.c, instead of a high level language such as the one provided >> by acpi. > > I meant, remove the code in rombios32.c. Sorry about the confusion. > Oh, so that's okay ;-) ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/