From mboxrd@z Thu Jan  1 00:00:00 1970
From: david ahern <daahern@cisco.com>
Subject: Re: still seeing network freezes with rtl8139 nic
Date: Mon, 25 Feb 2008 10:06:04 -0700
Message-ID: <47C2F57C.9040903@cisco.com>
References: <47BDC414.30301@cisco.com> <47C14371.9040405@qumranet.com>
	<47C1CA4F.3020605@cisco.com> <47C28256.7020908@qumranet.com>
	<47C2E896.7010805@cisco.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Cc: kvm-devel <kvm-devel@lists.sourceforge.net>
To: Avi Kivity <avi@qumranet.com>
Return-path: <kvm-devel-bounces@lists.sourceforge.net>
In-Reply-To: <47C2E896.7010805@cisco.com>
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/kvm-devel>,
	<mailto:kvm-devel-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum_name=kvm-devel>
List-Post: <mailto:kvm-devel@lists.sourceforge.net>
List-Help: <mailto:kvm-devel-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/kvm-devel>,
	<mailto:kvm-devel-request@lists.sourceforge.net?subject=subscribe>
Sender: kvm-devel-bounces@lists.sourceforge.net
Errors-To: kvm-devel-bounces@lists.sourceforge.net
List-Id: kvm.vger.kernel.org


david ahern wrote:
> Avi Kivity wrote:
>> - the in-kernel ioapic is buggy and needs the extra kicking the
>> optimization prevents.  Can be checked by re-adding the optimization to
>> kvm_ioapic_set_irq() (keeping it removed in qemu).  If it works, the
>> problem is in userspace.  If it fails, the problem is in the kernel.
>>
>> Something like
>>
>>  static int old_level[16];
>>
>>  if (level == old_level[irq])
>>     return;
>>  old_level[irq] = level;
>>

With the "if (!change) return;" taken out of pci_set_irq() and the above code
added to kvm_ioapic_set_irq() networking froze.

david

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/