From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [kvm-ppc-devel] Top level kvm-userspace directory getting crowded ... need new dir for qemu dependencies Date: Thu, 28 Feb 2008 10:16:26 +0200 Message-ID: <47C66DDA.7000808@qumranet.com> References: <1203922225.9895.6.camel@thinkpad.austin.ibm.com> <47C283BA.8000106@qumranet.com> <1204046679.6589.8.camel@thinkpad.austin.ibm.com> <1204129772.2532.31.camel@basalt> <47C59111.1080102@qumranet.com> <4D4A90C0-9771-4A83-9E22-CA9D3177F30D@suse.de> <1204138586.2532.56.camel@basalt> <47C5B941.2020509@qumranet.com> <1204142247.2532.70.camel@basalt> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel , kvm-ppc-devel To: Hollis Blanchard Return-path: In-Reply-To: <1204142247.2532.70.camel@basalt> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces@lists.sourceforge.net Errors-To: kvm-devel-bounces@lists.sourceforge.net List-Id: kvm.vger.kernel.org Hollis Blanchard wrote: >> It doesn't have to be a package; it can be as simple as a tarball that >> people have to make; && sudo make install before compiling kvm, the same >> as other prerequisite libraries. >> > > Sure. Let's put that tarball inside the qemu directory, and then have it > extracted and built automatically when the user types "make". > > I'm really not clear on what advantage you think will be gained here. > > If the package never changes in kvm-specific ways, there is no point in including it in kvm. The user can install it once, just like they install the X devel packages (for example) which we don't carry in kvm either. Is it indeed the case that no modifications are needed for kvm? >> The barrier should be whether we need to carry local changes or not. If >> we can use upstream as is, then it should be installed independently. >> > > So let me get this straight... you think it's cool to awk kernel source, > Awking the kernel source is not done for the sheer pleasure of it. It is painful to maintain and I only do it out of necessity. > but not to copy library code that was designed to be copied in the first > place? Seriously? Would it be more palatable to you if I ran awk over > arch/powerpc/boot/libdft? > Including the source in kvm is of course preferable to awk, but less preferable to an external dependency. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/