From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [kvm-ppc-devel] [PATCH] Fix qemu PPC breakage in monitor.c Date: Thu, 28 Feb 2008 10:23:08 +0200 Message-ID: <47C66F6C.6050003@qumranet.com> References: <1204151373.2532.112.camel@basalt> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel@lists.sourceforge.net, kvm-ppc-devel@lists.sourceforge.net, Jerone Young To: Hollis Blanchard Return-path: In-Reply-To: <1204151373.2532.112.camel@basalt> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces@lists.sourceforge.net Errors-To: kvm-devel-bounces@lists.sourceforge.net List-Id: kvm.vger.kernel.org Hollis Blanchard wrote: > On Wed, 2008-02-27 at 16:14 -0600, Jerone Young wrote: > >> # HG changeset patch >> # User Jerone Young >> # Date 1204150440 21600 >> # Branch merge >> # Node ID f255b23b6ef9461be4ee18fa0745f30c4fb66e6a >> # Parent 64a281615f436e65ca7fb2f3c2721c374fbfc8be >> Fix qemu PPC breakage in monitor.c >> >> Recent pull of qemu_cvs has added function "qemu_system_cpu_hot_add" to the function "do_cput_set_nr" in monitor.c . Issue is qemu_system_cpu_hot_add is defined in acpi.c which is only compiled for arch with target base i386 (which are i386 & x86-64). >> >> Signed-off-by: Jerone Young >> >> diff --git a/qemu/monitor.c b/qemu/monitor.c >> --- a/qemu/monitor.c >> +++ b/qemu/monitor.c >> @@ -357,7 +357,9 @@ static void do_cpu_set_nr(int value, con >> term_printf("invalid status: %s\n", status); >> return; >> } >> +#if defined(TARGET_I386) || defined(TARGET_X86_64) >> qemu_system_cpu_hot_add(value, state); >> +#endif >> } >> >> static void do_info_jit(void) >> > > This should be submitted to qemu-devel too, no? > > qemu hasn't merged the cpu hotplug patches (yet?). -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/