* [PATCH] Add --disable-cpu-emulation to qemu help screen
@ 2008-02-27 22:34 Jerone Young
2008-02-27 22:47 ` [kvm-ppc-devel] " Hollis Blanchard
2008-02-28 8:24 ` Avi Kivity
0 siblings, 2 replies; 5+ messages in thread
From: Jerone Young @ 2008-02-27 22:34 UTC (permalink / raw)
To: kvm-devel; +Cc: kvm-ppc-devel
# HG changeset patch
# User Jerone Young <jyoung5@us.ibm.com>
# Date 1204151598 21600
# Branch merge
# Node ID cd9eab52ef2d78809540518c4e18f4730d5d8400
# Parent f255b23b6ef9461be4ee18fa0745f30c4fb66e6a
Add --disable-cpu-emulation to qemu help screen.
This patch adds a line to the help screen of configure for qemu to show the option --disable-cpu-emulation
Signed-off-by: Jerone Young <jyoung5@us.ibm.com>
diff --git a/qemu/configure b/qemu/configure
--- a/qemu/configure
+++ b/qemu/configure
@@ -445,6 +445,7 @@ echo " --fmod-inc path to
echo " --fmod-inc path to FMOD includes"
echo " --enable-uname-release=R Return R for uname -r in usermode emulation"
echo " --sparc_cpu=V Build qemu for Sparc architecture v7, v8, v8plus, v8plusa, v9"
+echo " --no-cpu-emulation disables use of qemu cpu emulation code"
echo ""
echo "NOTE: The object files are built at the place where configure is launched"
exit 1
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [kvm-ppc-devel] [PATCH] Add --disable-cpu-emulation to qemu help screen
2008-02-27 22:34 [PATCH] Add --disable-cpu-emulation to qemu help screen Jerone Young
@ 2008-02-27 22:47 ` Hollis Blanchard
2008-02-28 16:16 ` Jerone Young
2008-02-28 8:24 ` Avi Kivity
1 sibling, 1 reply; 5+ messages in thread
From: Hollis Blanchard @ 2008-02-27 22:47 UTC (permalink / raw)
To: Jerone Young; +Cc: kvm-devel, kvm-ppc-devel
On Wed, 2008-02-27 at 16:34 -0600, Jerone Young wrote:
> # HG changeset patch
> # User Jerone Young <jyoung5@us.ibm.com>
> # Date 1204151598 21600
> # Branch merge
> # Node ID cd9eab52ef2d78809540518c4e18f4730d5d8400
> # Parent f255b23b6ef9461be4ee18fa0745f30c4fb66e6a
> Add --disable-cpu-emulation to qemu help screen.
>
> This patch adds a line to the help screen of configure for qemu to show the option --disable-cpu-emulation
>
> Signed-off-by: Jerone Young <jyoung5@us.ibm.com>
>
> diff --git a/qemu/configure b/qemu/configure
> --- a/qemu/configure
> +++ b/qemu/configure
> @@ -445,6 +445,7 @@ echo " --fmod-inc path to
> echo " --fmod-inc path to FMOD includes"
> echo " --enable-uname-release=R Return R for uname -r in usermode emulation"
> echo " --sparc_cpu=V Build qemu for Sparc architecture v7, v8, v8plus, v8plusa, v9"
> +echo " --no-cpu-emulation disables use of qemu cpu emulation code"
> echo ""
> echo "NOTE: The object files are built at the place where configure is launched"
> exit 1
The patch summary is correct, but the help text is not.
--
Hollis Blanchard
IBM Linux Technology Center
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [kvm-ppc-devel] [PATCH] Add --disable-cpu-emulation to qemu help screen
2008-02-27 22:47 ` [kvm-ppc-devel] " Hollis Blanchard
@ 2008-02-28 16:16 ` Jerone Young
0 siblings, 0 replies; 5+ messages in thread
From: Jerone Young @ 2008-02-28 16:16 UTC (permalink / raw)
To: Hollis Blanchard; +Cc: kvm-devel, kvm-ppc-devel
On Wed, 2008-02-27 at 16:47 -0600, Hollis Blanchard wrote:
> On Wed, 2008-02-27 at 16:34 -0600, Jerone Young wrote:
> > # HG changeset patch
> > # User Jerone Young <jyoung5@us.ibm.com>
> > # Date 1204151598 21600
> > # Branch merge
> > # Node ID cd9eab52ef2d78809540518c4e18f4730d5d8400
> > # Parent f255b23b6ef9461be4ee18fa0745f30c4fb66e6a
> > Add --disable-cpu-emulation to qemu help screen.
> >
> > This patch adds a line to the help screen of configure for qemu to show the option --disable-cpu-emulation
> >
> > Signed-off-by: Jerone Young <jyoung5@us.ibm.com>
> >
> > diff --git a/qemu/configure b/qemu/configure
> > --- a/qemu/configure
> > +++ b/qemu/configure
> > @@ -445,6 +445,7 @@ echo " --fmod-inc path to
> > echo " --fmod-inc path to FMOD includes"
> > echo " --enable-uname-release=R Return R for uname -r in usermode emulation"
> > echo " --sparc_cpu=V Build qemu for Sparc architecture v7, v8, v8plus, v8plusa, v9"
> > +echo " --no-cpu-emulation disables use of qemu cpu emulation code"
> > echo ""
> > echo "NOTE: The object files are built at the place where configure is launched"
> > exit 1
>
> The patch summary is correct, but the help text is not.
Exactly how is this not correct? While on PowerPC at the moment the TCG
code is not there (and you need this option anyway)...on x86 using this
option does mean by passing the TCG CPU emulation code. If you use this
option you have to be using KVM.. what text do you think whould be
better ?
>
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Add --disable-cpu-emulation to qemu help screen
2008-02-27 22:34 [PATCH] Add --disable-cpu-emulation to qemu help screen Jerone Young
2008-02-27 22:47 ` [kvm-ppc-devel] " Hollis Blanchard
@ 2008-02-28 8:24 ` Avi Kivity
2008-02-28 16:44 ` Jerone Young
1 sibling, 1 reply; 5+ messages in thread
From: Avi Kivity @ 2008-02-28 8:24 UTC (permalink / raw)
To: Jerone Young; +Cc: kvm-devel, kvm-ppc-devel
Jerone Young wrote:
> This patch adds a line to the help screen of configure for qemu to show the option --disable-cpu-emulation
>
>
Applied, thanks.
--
error compiling committee.c: too many arguments to function
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Add --disable-cpu-emulation to qemu help screen
2008-02-28 8:24 ` Avi Kivity
@ 2008-02-28 16:44 ` Jerone Young
0 siblings, 0 replies; 5+ messages in thread
From: Jerone Young @ 2008-02-28 16:44 UTC (permalink / raw)
To: Avi Kivity; +Cc: kvm-devel, kvm-ppc-devel
Whoops ok looks like I made a mistake with the help text. I use
"--no-cpu-emulation" .. when I meant "--disable-cpu-emulation" that was
in the summary. I think I got my self screwedup by the defines we use in
the code. This is what Hollis was pointing out.
Here is a more proper patch.
Signed-off-by: Jerone Young <jyoung5@us.ibm.com>
diff --git a/qemu/configure b/qemu/configure
--- a/qemu/configure
+++ b/qemu/configure
@@ -445,6 +445,7 @@ echo " --fmod-inc path to
echo " --fmod-inc path to FMOD includes"
echo " --enable-uname-release=R Return R for uname -r in usermode emulation"
echo " --sparc_cpu=V Build qemu for Sparc architecture v7, v8, v8plus, v8plusa, v9"
+echo " --disable-cpu-emulation disable use of qemu cpu emulation code"
echo ""
echo "NOTE: The object files are built at the place where configure is launched"
exit 1
On Thu, 2008-02-28 at 10:24 +0200, Avi Kivity wrote:
> Jerone Young wrote:
> > This patch adds a line to the help screen of configure for qemu to show the option --disable-cpu-emulation
> >
> >
>
> Applied, thanks.
>
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2008-02-28 16:44 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-02-27 22:34 [PATCH] Add --disable-cpu-emulation to qemu help screen Jerone Young
2008-02-27 22:47 ` [kvm-ppc-devel] " Hollis Blanchard
2008-02-28 16:16 ` Jerone Young
2008-02-28 8:24 ` Avi Kivity
2008-02-28 16:44 ` Jerone Young
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox