From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 4/8] KVM: MMU: hypercall based pte updates and TLB flushes Date: Tue, 04 Mar 2008 11:33:46 +0200 Message-ID: <47CD177A.9050603@qumranet.com> References: <1204475481-16583-5-git-send-email-avi@qumranet.com> <20080303144335.GA3281@dmt> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel@lists.sourceforge.net To: Marcelo Tosatti Return-path: In-Reply-To: <20080303144335.GA3281@dmt> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces@lists.sourceforge.net Errors-To: kvm-devel-bounces@lists.sourceforge.net List-Id: kvm.vger.kernel.org Marcelo Tosatti wrote: > Hi Avi, > > Looks nice. > > On Sun, Mar 02, 2008 at 06:31:17PM +0200, Avi Kivity wrote: > >> +int kvm_pv_mmu_op(struct kvm_vcpu *vcpu, unsigned long bytes, >> + gpa_t addr, unsigned long *ret) >> +{ >> + int r; >> + struct kvm_pv_mmu_op_buffer buffer; >> > > Perhaps this structure is a little large to be on stack. > > 512 bytes should be fine as this isn't part of a particularly deep path. If it gives us trouble we can reduce it as the size is independent from the guest buffer size. >> + down_read(¤t->mm->mmap_sem); >> + down_read(&vcpu->kvm->slots_lock); >> > > The order should be slots_locks then mmap_sem. Need some comment in the > code. > Changed, thanks. As the patchset (less cr3 caching) passed the regression tests I'll apply it. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/