Re: KVM Test result, kernel daf4de3.., userspace 724f8a9.. One new issue

[Avi Kivity <avi@qumranet.com>]

Yunfeng Zhao wrote:
>  Hi, all,
>  
> This is today's KVM test result against kvm.git 
> daf4de30ec718b16798aba07e9f25fd9e6ba9e53 and kvm-userspace.git 
> 724f8a940ec0e78e607c051e6e82ca2f5055b1e1.
> In today's testing , save/restore crashed host once on pae/ia32e hosts.
> One  new issue has been found:
> 1. blue screen when booting 64bits windows guests 
> </tracker/index.php?func=detail&aid=1906751&group_id=180599&atid=893831>
> https://sourceforge.net/tracker/index.php?func=detail&aid=1906751&group_id=180599&atid=893831
>
>   

This was caused by


commit 3a001629eea909b2aa97f001a9db4700f15d986b
Author: Amit Shah <amit.shah@qumranet.com>
Date:   Thu Feb 28 16:06:15 2008 +0530

    KVM: is_long_mode() should check for EFER.LMA

    is_long_mode currently checks the LongModeEnable bit in
    EFER instead of the LongModeActive bit. This is wrong, but
    we survived this till now since it wasn't triggered. This
    breaks guests that go from long mode to compatibility mode.

    This is noticed on a solaris guest and fixes bug #1842160

    Signed-off-by: Amit Shah <amit.shah@qumranet.com>
    Signed-off-by: Avi Kivity <avi@qumranet.com>

diff --git a/arch/x86/kvm/mmu.h b/arch/x86/kvm/mmu.h
index e64e9f5..d83225e 100644
--- a/arch/x86/kvm/mmu.h
+++ b/arch/x86/kvm/mmu.h
@@ -26,7 +26,7 @@ static inline int kvm_mmu_reload(struct kvm_vcpu *vcpu)
 static inline int is_long_mode(struct kvm_vcpu *vcpu)
 {
 #ifdef CONFIG_X86_64
-       return vcpu->arch.shadow_efer & EFER_LME;
+       return vcpu->arch.shadow_efer & EFER_LMA;
 #else
        return 0;
 #endif


I'm reverting that patch.

-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/