From: Anthony Liguori <anthony@codemonkey.ws>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: kvm-devel@lists.sourceforge.net,
Marcelo Tosatti <mtosatti@redhat.com>,
Avi Kivity <avi@qumranet.com>, Glauber Costa <gcosta@redhat.com>
Subject: Re: [patch 23/23] QEMU/KVM: device hot-remove
Date: Tue, 04 Mar 2008 13:32:22 -0600 [thread overview]
Message-ID: <47CDA3C6.6080407@codemonkey.ws> (raw)
In-Reply-To: <20080304191843.GM6713@redhat.com>
Daniel P. Berrange wrote:
> Removing based on pci device number is very un-pleasant, since its not something
> the user of the monitor cares about. Nor do they even know what the PCI device number
> assigned by 'pci_add' is.
>
> As with addition, I'd like separate commands for NIC vs Drive, and for the removal
> key to be based upon the same data used for addition. eg so one can remove the
> NIC based on its MAC address, or remove the drive based on the (if,bus,unit,filename)
> data items.
>
> nic_remove [vlan=n][,macaddr=addr][,model=type]
> drive_remove [[file=file][,if=type][,bus=n][,unit=m][,media=d][index=i]]
>
> Though, perhaps still allow removal based on the PCI device ID as an alternative
> for those who happen to have that data available.
>
pci_remove is consistent with usb_del and things like stopcapture. The
thing to add would be an "info pci" that let a user associate the slot
number with higher level information about the device.
Regards,
Anthony Liguori
> Regards,
> Dan.
>
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
next prev parent reply other threads:[~2008-03-04 19:32 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-04 18:34 [patch 00/23] [RFC] QEMU/KVM ACPI PCI hotplug Marcelo Tosatti
2008-03-04 18:34 ` [patch 01/23] QEMU/KVM: add PCI IRQ routing information up to slot 32 Marcelo Tosatti
2008-03-05 5:40 ` Avi Kivity
2008-03-04 18:34 ` [patch 02/23] QEMU/KVM: add devices to represent PCI slots with _EJ0 method Marcelo Tosatti
2008-03-04 18:34 ` [patch 03/23] QEMU/KVM: add OperationRegion and GPE handler for add/removal notification Marcelo Tosatti
2008-03-04 18:34 ` [patch 04/23] QEMU/KVM: add pci_find_bus Marcelo Tosatti
2008-03-04 18:34 ` [patch 05/23] QEMU/KVM: return PCIDevice on net device init and record devfn Marcelo Tosatti
2008-03-04 18:34 ` [patch 06/23] QEMU/KVM: pci hotplug GPE support Marcelo Tosatti
2008-03-04 18:34 ` [patch 07/23] QEMU/KVM: dynamic drive/drive_opt index allocation Marcelo Tosatti
2008-03-04 18:34 ` [patch 08/23] QEMU/KVM: dynamic nic info " Marcelo Tosatti
2008-03-04 18:34 ` [patch 09/23] QEMU/KVM: drive removal support Marcelo Tosatti
2008-03-04 18:34 ` [patch 10/23] QEMU/KVM: record devfn on block driver instance Marcelo Tosatti
2008-03-04 18:34 ` [patch 11/23] QEMU/KVM: move drives_opt for external use Marcelo Tosatti
2008-03-04 18:34 ` [patch 12/23] QEMU/KVM: net/drive add/remove tweaks Marcelo Tosatti
2008-03-04 18:34 ` [patch 13/23] QEMU/KVM: add net_client_uninit Marcelo Tosatti
2008-03-04 18:34 ` [patch 14/23] QEMU/KVM: device hot-add Marcelo Tosatti
2008-03-04 19:14 ` Daniel P. Berrange
2008-03-04 19:30 ` Anthony Liguori
2008-03-04 19:53 ` Daniel P. Berrange
2008-03-04 21:44 ` Itamar Heim
2008-03-05 5:50 ` Avi Kivity
2008-03-11 14:18 ` Marcelo Tosatti
2008-03-04 18:34 ` [patch 15/23] QEMU/KVM: add pci_find_device Marcelo Tosatti
2008-03-04 18:34 ` [patch 16/23] QEMU/KVM: add cpu_unregister_io_memory and make io mem table index dynamic Marcelo Tosatti
2008-03-04 18:34 ` [patch 17/23] QEMU/KVM: notify _EJ0 through _SEJ OperationRegion Marcelo Tosatti
2008-03-04 18:34 ` [patch 18/23] QEMU/KVM: handle SEJ notifications Marcelo Tosatti
2008-03-04 18:34 ` [patch 19/23] QEMU/KVM: add qemu_free_irqs Marcelo Tosatti
2008-03-04 18:34 ` [patch 20/23] QEMU/KVM: add pci_unregister_device Marcelo Tosatti
2008-03-04 18:34 ` [patch 21/23] QEMU/KVM: LSI SCSI unregister callback Marcelo Tosatti
2008-03-04 18:34 ` [patch 22/23] QEMU/KVM: zero ioport_opaque on isa_unassign_ioport Marcelo Tosatti
2008-03-04 18:34 ` [patch 23/23] QEMU/KVM: device hot-remove Marcelo Tosatti
2008-03-04 19:18 ` Daniel P. Berrange
2008-03-04 19:32 ` Anthony Liguori [this message]
2008-03-04 20:00 ` Marcelo Tosatti
2008-03-04 20:06 ` Daniel P. Berrange
2008-03-05 6:28 ` Avi Kivity
2008-03-05 5:46 ` Avi Kivity
2008-03-05 6:47 ` Avi Kivity
2008-03-05 6:00 ` [patch 00/23] [RFC] QEMU/KVM ACPI PCI hotplug Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47CDA3C6.6080407@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=avi@qumranet.com \
--cc=berrange@redhat.com \
--cc=gcosta@redhat.com \
--cc=kvm-devel@lists.sourceforge.net \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox