From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: loop in copy_user_generic_string Date: Wed, 05 Mar 2008 08:50:41 +0200 Message-ID: <47CE42C1.5040701@qumranet.com> References: <47CD73DF.6070502@qumranet.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel@lists.sourceforge.net, Zdenek Kabelac To: Andi Kleen Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces@lists.sourceforge.net Errors-To: kvm-devel-bounces@lists.sourceforge.net List-Id: kvm.vger.kernel.org Andi Kleen wrote: > Avi Kivity writes: > >> Most likely movs emulation is broken for long counts. Please post a >> disassembly of copy_user_generic_string to make sure we're looking at >> the same code. >> > > Be careful -- this code is patched at runtime and what you > see in the vmlinux is not necessarily the same that is executed > > If the disassembled instruction isn't marked as an alternative in the source, then it can't be patched, right? > Incidentially that might cause problems. Specific to kvm? how? -- Do not meddle in the internals of kernels, for they are subtle and quick to panic. ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/