From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH][EXTBOOT] Fix read drive parameters to solve Grub Error 18 Date: Wed, 05 Mar 2008 09:06:49 +0200 Message-ID: <47CE4689.1000009@qumranet.com> References: <1204652673-11492-1-git-send-email-aliguori@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel@lists.sourceforge.net To: Anthony Liguori Return-path: In-Reply-To: <1204652673-11492-1-git-send-email-aliguori@us.ibm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces@lists.sourceforge.net Errors-To: kvm-devel-bounces@lists.sourceforge.net List-Id: kvm.vger.kernel.org Anthony Liguori wrote: > In certain circumstances, the calculated CHS can result in a total number of > sectors that is less than the actual number of sectors. I'm not entirely > sure why this upsets grub, but it seems to be the source of the Grub Error 18 > that sometimes occurs when using extboot. > > The solution is to implement the read drive parameters function and return the > actual numbers of sectors. This requires changing the QEMU <=> extboot > interface as this was not previously passed to extboot. > > Applied, thanks. Please separate qemu and extboot patches in the future. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic. ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/