From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [PATCH] virtio-balloon: do not attempt to release more than available pages Date: Wed, 05 Mar 2008 13:42:53 -0600 Message-ID: <47CEF7BD.3060200@codemonkey.ws> References: <20080305162832.GA11563@dmt> <47CED15E.4090504@qumranet.com> <20080305181228.GA12152@dmt> <47CEE9E0.3080204@codemonkey.ws> <20080305193941.GA13856@dmt> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel , Avi Kivity To: Marcelo Tosatti Return-path: In-Reply-To: <20080305193941.GA13856@dmt> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces@lists.sourceforge.net Errors-To: kvm-devel-bounces@lists.sourceforge.net List-Id: kvm.vger.kernel.org Marcelo Tosatti wrote: >>> I guess the description was not clear, you understood the opposite. >>> >>> The problem is when the target for total guest pages (not balloon target >>> size) is set to be larger than the amount of total pages the guest has >>> booted with. What happens then is that the driver tries to release pages >>> >> >from the balloon, without checking if there are any: >> >>> >>> >> target in the config space is target balloon size, not target for total >> guest pages. So how is it ever possible for this condition to occur? >> > > Set the target in QEMU to be larger than guest ram size. The config > space variable will be set negatively, so guest attempts to release > pages from the balloon. > > Is an __le32 signed? If so, we should just use an unsigned type. Regards, Anthony Liguori ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/