public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@qumranet.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Marcelo Tosatti <marcelo@kvack.org>,
	kvm-devel <kvm-devel@lists.sourceforge.net>
Subject: Re: [PATCH] virtio-balloon: do not attempt to release more	than available pages
Date: Thu, 06 Mar 2008 09:06:26 +0200	[thread overview]
Message-ID: <47CF97F2.2080108@qumranet.com> (raw)
In-Reply-To: <47CEF7BD.3060200@codemonkey.ws>

Anthony Liguori wrote:
>>
>> Set the target in QEMU to be larger than guest ram size. The config
>> space variable will be set negatively, so guest attempts to release
>> pages from the balloon.
>>
>>   
>>     
>
> Is an __le32 signed?  If so, we should just use an unsigned type.
>
>   

That would balloon the guest into oblivion if the same condition happened.

-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

  reply	other threads:[~2008-03-06  7:06 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-05 16:28 [PATCH] virtio-balloon: do not attempt to release more than available pages Marcelo Tosatti
2008-03-05 16:59 ` Avi Kivity
2008-03-05 18:12   ` Marcelo Tosatti
2008-03-05 18:13     ` Avi Kivity
2008-03-05 18:43     ` Anthony Liguori
2008-03-05 19:39       ` Marcelo Tosatti
2008-03-05 19:42         ` Anthony Liguori
2008-03-06  7:06           ` Avi Kivity [this message]
2008-03-05 18:42   ` Anthony Liguori
2008-03-05 22:39 ` Rusty Russell
2008-03-08 19:06   ` Marcelo Tosatti
2008-03-11  0:26     ` Rusty Russell
2008-03-11  0:52       ` Anthony Liguori
2008-03-11 11:54         ` Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47CF97F2.2080108@qumranet.com \
    --to=avi@qumranet.com \
    --cc=anthony@codemonkey.ws \
    --cc=kvm-devel@lists.sourceforge.net \
    --cc=marcelo@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox