From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] virtio-balloon: do not attempt to release more than available pages Date: Thu, 06 Mar 2008 09:06:26 +0200 Message-ID: <47CF97F2.2080108@qumranet.com> References: <20080305162832.GA11563@dmt> <47CED15E.4090504@qumranet.com> <20080305181228.GA12152@dmt> <47CEE9E0.3080204@codemonkey.ws> <20080305193941.GA13856@dmt> <47CEF7BD.3060200@codemonkey.ws> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm-devel To: Anthony Liguori Return-path: In-Reply-To: <47CEF7BD.3060200@codemonkey.ws> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces@lists.sourceforge.net Errors-To: kvm-devel-bounces@lists.sourceforge.net List-Id: kvm.vger.kernel.org Anthony Liguori wrote: >> >> Set the target in QEMU to be larger than guest ram size. The config >> space variable will be set negatively, so guest attempts to release >> pages from the balloon. >> >> >> > > Is an __le32 signed? If so, we should just use an unsigned type. > > That would balloon the guest into oblivion if the same condition happened. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic. ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/