Re: [PATCH] KVM: Add reset support for in kernel PIT

[Avi Kivity <avi@qumranet.com>]

Yang, Sheng wrote:
> From 2d08f4266a8f47d9c52db9d4f629ab5d2f8fd044 Mon Sep 17 00:00:00 2001
> From: Sheng Yang <sheng.yang@intel.com>
> Date: Thu, 13 Mar 2008 10:22:26 +0800
> Subject: [PATCH] KVM: Add reset support for in kernel PIT
>
> Separate the reset part and prepare for reset support.
>
>   

> diff --git a/arch/x86/kvm/i8254.c b/arch/x86/kvm/i8254.c
> index 7776f50..06a241a 100644
> --- a/arch/x86/kvm/i8254.c
> +++ b/arch/x86/kvm/i8254.c
> @@ -476,12 +476,28 @@ static int speaker_in_range(struct kvm_io_device *this, 
> gpa_t addr)
>  	return (addr == KVM_SPEAKER_BASE_ADDRESS);
>  }
>
> -struct kvm_pit *kvm_create_pit(struct kvm *kvm)
> +void kvm_pit_reset(struct kvm_pit *pit)
>  {
>  	int i;
> +	struct kvm_kpit_channel_state *c;
> +
> +	mutex_lock(&pit->pit_state.lock);
> +	for (i = 0; i < 3; i++) {
> +		c = &pit->pit_state.channels[i];
> +		c->mode = 0xff;
> +		c->gate = (i != 2);
> +		pit_load_count(pit->kvm, i, 0);
> +	}
> +	mutex_unlock(&pit->pit_state.lock);
> +
> +	atomic_set(&pit->pit_state.pit_timer.pending, 0);
> +	pit->pit_state.inject_pending = 1;
> +}
>   

Don't you need an hrtimer_cancel() here, in case this is a true reset 
and not part of initialization?

-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/