From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@qumranet.com>
Subject: Re: [PATCH RFC 0/4]Porting Xentrace to kvm
Date: Sun, 16 Mar 2008 17:53:38 +0200
Message-ID: <47DD4282.6010201@qumranet.com>
References: <9D7649D18729DE4BB2BD7B494F7FEDC201084D2D@pdsmsx415.ccr.corp.intel.com>
	<47DD3CBB.9050201@qumranet.com> <47DD4085.7010607@web.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Cc: kvm-devel <kvm-devel@lists.sourceforge.net>,
	"Liu,  Eric E" <eric.e.liu@intel.com>
To: Jan Kiszka <jan.kiszka@web.de>
Return-path: <kvm-devel-bounces@lists.sourceforge.net>
In-Reply-To: <47DD4085.7010607@web.de>
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/kvm-devel>,
	<mailto:kvm-devel-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum_name=kvm-devel>
List-Post: <mailto:kvm-devel@lists.sourceforge.net>
List-Help: <mailto:kvm-devel-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/kvm-devel>,
	<mailto:kvm-devel-request@lists.sourceforge.net?subject=subscribe>
Sender: kvm-devel-bounces@lists.sourceforge.net
Errors-To: kvm-devel-bounces@lists.sourceforge.net
List-Id: kvm.vger.kernel.org

Jan Kiszka wrote:
> Avi Kivity wrote:
>   
>> Liu, Eric E wrote:
>>     
>>> Hi,
>>> The following patches port xentrace to kvm which is useful for
>>> performance tuning and debugging.
>>>
>>> It is designed to allow debugging traces of kvm to be generated on
>>> Up/Smp machines. Each trace entry is outputted in a trace ring buffer
>>> for per cpu which is mapped to userspace, and the userspace tools can
>>> analyze the data according to some formats definitions.
>>>
>>> Since we already have had debugfs_entries and some other kernel debug
>>> mechanism to use, does this kvmtrace make sense? Any comment is
>>> welcomed. 
>>>   
>>>       
>> This looks very useful.  While kvm_stat provides good data, this is much 
>> more in depth.
>>
>> The kernel already contains a method of transferring percpu data to 
>> userspace; see Documentation/filesystems/relay.txt.  It supports mmap() 
>> and read().  Please see if it is a good fit.
>>     
>
> I would also suggest to use the new kernel standard for instrumentation:
> trace_mark().
>
> This would also allow to reuse the trace points with other tracer and
> maybe even obsolete a separate transportation channel, e.g. when LTTng
> is once :-/ merged.
>   

Can one have markers automatically recorded?  Or do you need to connect 
the marker with a logging function?

If the latter, it's too difficult to use.

-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/