From: Anthony Liguori <anthony@codemonkey.ws>
To: Jerone Young <jyoung5@us.ibm.com>
Cc: kvm-devel@lists.sourceforge.net, kvm-ppc-devel@lists.sourceforge.net
Subject: Re: [PATCH 3 of 7] Create new load_uimage() & gunzip support to uboot loader in Qemu
Date: Wed, 19 Mar 2008 14:25:49 -0500 [thread overview]
Message-ID: <47E168BD.3020506@codemonkey.ws> (raw)
In-Reply-To: <05d6146c77066b2bc0dd.1205953276@thinkpad.austin.ibm.com>
>
> - cpu_physical_memory_write_rom(hdr->ih_load, data, hdr->ih_size);
> -
> - return hdr->ih_size;
> + tmp_loaded_image_size = hdr->ih_size;
> +
> + if (hdr->ih_comp == IH_COMP_GZIP) {
> + uncompressed_data = qemu_malloc(MAX_KERNEL_SIZE);
> + ret = gunzip(uncompressed_data, MAX_KERNEL_SIZE,
> + (unsigned char *) data,
> + &tmp_loaded_image_size);
> +
> + if (ret < 0) {
> + fprintf(stderr, "Unable to decompress gziped image!\n");
> + goto fail;
> + }
> +
> + qemu_free(data);
> + cpu_physical_memory_write_rom(hdr->ih_load, uncompressed_data,
> + tmp_loaded_image_size);
> + }
> + else {
>
You've still got braces issues.
Regards,
Anthony Liguori
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
next prev parent reply other threads:[~2008-03-19 19:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-19 19:01 [PATCH 0 of 7] [v5] PowerPC kvm-userspace patches Jerone Young
2008-03-19 19:01 ` [PATCH 1 of 7] Add libfdt to KVM userspace Jerone Young
2008-03-19 19:01 ` [PATCH 2 of 7] Add libfdt support to qemu Jerone Young
2008-03-19 19:01 ` [PATCH 3 of 7] Create new load_uimage() & gunzip support to uboot loader in Qemu Jerone Young
2008-03-19 19:25 ` Anthony Liguori [this message]
2008-03-19 19:01 ` [PATCH 4 of 7] Add PPC 440EP bamboo board device tree source & binary into qemu Jerone Young
2008-03-19 19:01 ` [PATCH 5 of 7] Add dynamic device tree manipulation & change uboot loader for PPC bamboo board model Jerone Young
2008-03-19 19:30 ` Anthony Liguori
2008-03-19 19:36 ` Jerone Young
2008-03-19 19:01 ` [PATCH 6 of 7] Modify PPC bamboo & ppc440 board models Jerone Young
2008-03-19 19:01 ` [PATCH 7 of 7] Add ability to specify ram on command line for bamboo board model Jerone Young
-- strict thread matches above, loose matches on Subject: below --
2008-03-19 20:00 [PATCH 0 of 7] [v6] PowerPC kvm-userspace patches Jerone Young
2008-03-19 20:00 ` [PATCH 3 of 7] Create new load_uimage() & gunzip support to uboot loader in Qemu Jerone Young
2008-03-19 14:45 [PATCH 0 of 7] PowerPC kvm-userspace patches Jerone Young
2008-03-19 14:45 ` [PATCH 3 of 7] Create new load_uimage() & gunzip support to uboot loader in Qemu Jerone Young
2008-03-18 20:06 [PATCH 0 of 7] [v3] PowerPC kvm-userspace patches Jerone Young
2008-03-18 20:06 ` [PATCH 3 of 7] Create new load_uimage() & gunzip support to uboot loader in Qemu Jerone Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47E168BD.3020506@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=jyoung5@us.ibm.com \
--cc=kvm-devel@lists.sourceforge.net \
--cc=kvm-ppc-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox