From mboxrd@z Thu Jan  1 00:00:00 1970
From: Anthony Liguori <anthony@codemonkey.ws>
Subject: Re: [PATCH 3 of 7] Create new load_uimage() & gunzip
 support to uboot	loader in Qemu
Date: Wed, 19 Mar 2008 14:25:49 -0500
Message-ID: <47E168BD.3020506@codemonkey.ws>
References: <05d6146c77066b2bc0dd.1205953276@thinkpad.austin.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Cc: kvm-devel@lists.sourceforge.net,
	kvm-ppc-devel@lists.sourceforge.net
To: Jerone Young <jyoung5@us.ibm.com>
Return-path: <kvm-devel-bounces@lists.sourceforge.net>
In-Reply-To: <05d6146c77066b2bc0dd.1205953276@thinkpad.austin.ibm.com>
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/kvm-devel>,
	<mailto:kvm-devel-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum_name=kvm-devel>
List-Post: <mailto:kvm-devel@lists.sourceforge.net>
List-Help: <mailto:kvm-devel-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/kvm-devel>,
	<mailto:kvm-devel-request@lists.sourceforge.net?subject=subscribe>
Sender: kvm-devel-bounces@lists.sourceforge.net
Errors-To: kvm-devel-bounces@lists.sourceforge.net
List-Id: kvm.vger.kernel.org


>  
> -    cpu_physical_memory_write_rom(hdr->ih_load, data, hdr->ih_size);
> -
> -    return hdr->ih_size;
> +    tmp_loaded_image_size = hdr->ih_size;
> +    
> +    if (hdr->ih_comp == IH_COMP_GZIP) {
> +        uncompressed_data = qemu_malloc(MAX_KERNEL_SIZE);
> +        ret = gunzip(uncompressed_data, MAX_KERNEL_SIZE,
> +                    (unsigned char *) data, 
> +                    &tmp_loaded_image_size);
> +   
> +        if (ret < 0) {
> +            fprintf(stderr, "Unable to decompress gziped image!\n");
> +            goto fail;
> +        }
> +
> +        qemu_free(data);
> +        cpu_physical_memory_write_rom(hdr->ih_load, uncompressed_data,
> +                                    tmp_loaded_image_size);
> +    }
> +    else {
>   

You've still got braces issues.

Regards,

Anthony Liguori


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/