From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Otte Subject: Re: [RFC/PATCH 14/15] guest: detect when running on kvm Date: Fri, 21 Mar 2008 12:12:04 +0100 Message-ID: <47E39804.4030605@de.ibm.com> References: <1206028710.6690.21.camel@cotte.boeblingen.de.ibm.com> <1206030326.6690.65.camel@cotte.boeblingen.de.ibm.com> <20080320175357.GA30959@infradead.org> <47E2CAFF.3070203@de.ibm.com> <20080320194137.GA9975@infradead.org> <47E2D034.4090600@de.ibm.com> <20080320212255.GA4225@osiris.boeblingen.de.ibm.com> Reply-To: carsteno@de.ibm.com Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: carsteno@linux.vnet.ibm.com, Christian Ehrhardt , arnd@arndb.de, hollisb@us.ibm.com, kvm-devel@lists.sourceforge.net, heicars2@linux.vnet.ibm.com, mschwid2@linux.vnet.ibm.com, jeroney@us.ibm.com, Avi Kivity , virtualization@lists.linux-foundation.org, Christoph Hellwig , borntrae@linux.vnet.ibm.com, rvdheij@gmail.com, Olaf Schnapper , jblunck@suse.de, "Zhang, Xiantao" To: Heiko Carstens Return-path: In-Reply-To: <20080320212255.GA4225@osiris.boeblingen.de.ibm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces@lists.sourceforge.net Errors-To: kvm-devel-bounces@lists.sourceforge.net List-Id: kvm.vger.kernel.org MAILER-DAEMON@linux.ibm.com wrote: > Since when do we have symbolic names for the bits? > It was always on my todo list to do a cleanup and replace the numbers > we use everywhere with names. Especially since we have clashes from time > to time... but that didn't hurt enough yet, obviously. > But now that you volunteered to take care of this... :) Right. We only have defines for (machine_flags & bit). Looks to me like the bits really should have a name on them. I've created a patch that does this, but I want to talk it over with Martin before sending that one out. ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/