From mboxrd@z Thu Jan  1 00:00:00 1970
From: Carsten Otte <cotte@de.ibm.com>
Subject: Re: [RFC/PATCH 06/15] kvm-s390: sie intercept handling
Date: Fri, 21 Mar 2008 12:26:29 +0100
Message-ID: <47E39B65.6010201@de.ibm.com>
References: <1206028710.6690.21.camel@cotte.boeblingen.de.ibm.com>
	<1206030302.6690.57.camel@cotte.boeblingen.de.ibm.com>
	<47E393A5.2010602@qumranet.com>
Reply-To: carsteno@de.ibm.com
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Cc: Christian Ehrhardt <EHRHARDT@de.ibm.com>, arnd@arndb.de,
	hollisb@us.ibm.com, kvm-devel@lists.sourceforge.net,
	mschwid2@linux.vnet.ibm.com, heicars2@linux.vnet.ibm.com,
	jeroney@us.ibm.com, borntrae@linux.vnet.ibm.com,
	virtualization@lists.linux-foundation.org, rvdheij@gmail.com,
	Olaf Schnapper <os@de.ibm.com>, jblunck@suse.de,
	"Zhang,  Xiantao" <xiantao.zhang@intel.com>
To: Avi Kivity <avi@qumranet.com>
Return-path: <kvm-devel-bounces@lists.sourceforge.net>
In-Reply-To: <47E393A5.2010602@qumranet.com>
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/kvm-devel>,
	<mailto:kvm-devel-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum_name=kvm-devel>
List-Post: <mailto:kvm-devel@lists.sourceforge.net>
List-Help: <mailto:kvm-devel-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/kvm-devel>,
	<mailto:kvm-devel-request@lists.sourceforge.net?subject=subscribe>
Sender: kvm-devel-bounces@lists.sourceforge.net
Errors-To: kvm-devel-bounces@lists.sourceforge.net
List-Id: kvm.vger.kernel.org

Avi Kivity wrote:
> Carsten Otte wrote:
>>  
>>  /* for KVM_RUN, returned by mmap(vcpu_fd, offset=0) */
>>  struct kvm_run {
>> @@ -138,6 +139,14 @@ struct kvm_run {
>>              __u32 is_write;
>>              __u32 pad;
>>          } tpr_access;
>> +        /* KVM_EXIT_S390_SIEIC */
>> +        struct {
>> +            __u8 icptcode;
>> +            __u64 mask; /* psw upper half */
>> +            __u64 addr; /* psw lower half */
>> +            __u16 ipa;
>> +            __u32 ipb;
>> +        } s390_sieic;
>>          /* Fix the size of the union. */
>>          char padding[256];
>>      };
>>
>>   
> 
> Do you support 32-bit userspace on 64-bit kernel?  If so, this is likely 
> badly aligned.
32bit userspace is not pracitcal, current enterprise distributions 
come with 64bit only on s390. Nevertheless, I don't get your point on 
allignment. What is the problem caused by the struct, and how can I 
solve it?

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/