From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] kvm.h: __user requires compiler.h Date: Sun, 23 Mar 2008 10:42:27 +0200 Message-ID: <47E617F3.7080509@qumranet.com> References: <200803121810.46055.borntraeger@de.ibm.com> <47E41AC9.1030003@codemonkey.ws> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel@lists.sourceforge.net, Christian Borntraeger To: Anthony Liguori Return-path: In-Reply-To: <47E41AC9.1030003@codemonkey.ws> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces@lists.sourceforge.net Errors-To: kvm-devel-bounces@lists.sourceforge.net List-Id: kvm.vger.kernel.org Anthony Liguori wrote: > This patch breaks QEMU build when doing a 'make sync'. When you do a > top-level ./configure, libkvm is built with kerneldir pointing to > kvm-userspace/kernel/include. While linux/kvm.h is present there, > there isn't a linux/compiler.h. > > The host kernelpath isn't normally part of the libkvm or QEMU build. > So we have a couple options. > > 1) make the host kernelpath (/lib/modules/$(uname -r)/build/include) > part of the libkvm/QEMU build. > > 2) Do something else about __user > > Suggestions? #1 might be a pain since there may be include conflicts > between the host kernel include and kernel/include. > We could hack 'make sync' to strip out __user (just like we run unifdef). Of course the reasons for including linux/compiler.h are still valid, so it needs to remain. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/