public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@qumranet.com>
To: Zdenek Kabelac <zdenek.kabelac@gmail.com>
Cc: kvm-devel@lists.sourceforge.net
Subject: Re: Qemu-kvm is leaking my memory ???
Date: Sun, 23 Mar 2008 14:20:27 +0200	[thread overview]
Message-ID: <47E64B0B.7040401@qumranet.com> (raw)
In-Reply-To: <47E62F75.4030009@qumranet.com>

[-- Attachment #1: Type: text/plain, Size: 276 bytes --]

Avi Kivity wrote:
>
> I see the same issue too now, and am investigating.
>

The attached patch should fix the issue.  It is present in 2.6.25-rc6 
only, and not in kvm.git, which is why few people noticed it.

-- 
error compiling committee.c: too many arguments to function


[-- Attachment #2: fix-kvm-2.6.25-rc6-leak.patch --]
[-- Type: text/x-patch, Size: 463 bytes --]

diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c
index 4ba85d9..e55af12 100644
--- a/arch/x86/kvm/mmu.c
+++ b/arch/x86/kvm/mmu.c
@@ -1412,7 +1412,7 @@ static void mmu_guess_page_from_pte_write(struct kvm_vcpu *vcpu, gpa_t gpa,
 	up_read(&current->mm->mmap_sem);
 
 	vcpu->arch.update_pte.gfn = gfn;
-	vcpu->arch.update_pte.page = gfn_to_page(vcpu->kvm, gfn);
+	vcpu->arch.update_pte.page = page;
 }
 
 void kvm_mmu_pte_write(struct kvm_vcpu *vcpu, gpa_t gpa,

[-- Attachment #3: Type: text/plain, Size: 228 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

[-- Attachment #4: Type: text/plain, Size: 158 bytes --]

_______________________________________________
kvm-devel mailing list
kvm-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-devel

  reply	other threads:[~2008-03-23 12:20 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-14 22:14 Qemu-kvm is leaking my memory ??? Zdenek Kabelac
2008-03-16 13:46 ` Avi Kivity
2008-03-19 15:05   ` Zdenek Kabelac
2008-03-19 15:56     ` Avi Kivity
2008-03-19 17:31       ` Zdenek Kabelac
2008-03-19 17:40         ` Avi Kivity
2008-03-23  9:26           ` Zdenek Kabelac
2008-03-23 10:22             ` Avi Kivity
2008-03-23 12:20               ` Avi Kivity [this message]
2008-03-23 23:06                 ` Zdenek Kabelac
2008-03-24 10:09                   ` Avi Kivity
2008-03-24 16:18                     ` Avi Kivity
2008-03-24 21:42                       ` Zdenek Kabelac

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47E64B0B.7040401@qumranet.com \
    --to=avi@qumranet.com \
    --cc=kvm-devel@lists.sourceforge.net \
    --cc=zdenek.kabelac@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox