From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: Qemu-kvm is leaking my memory ??? Date: Sun, 23 Mar 2008 14:20:27 +0200 Message-ID: <47E64B0B.7040401@qumranet.com> References: <47DD24C1.7010900@qumranet.com> <47E137AD.1000400@qumranet.com> <47E14FF8.60708@qumranet.com> <47E62F75.4030009@qumranet.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------030404050700070704050902" Cc: kvm-devel@lists.sourceforge.net To: Zdenek Kabelac Return-path: In-Reply-To: <47E62F75.4030009@qumranet.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces@lists.sourceforge.net Errors-To: kvm-devel-bounces@lists.sourceforge.net List-Id: kvm.vger.kernel.org This is a multi-part message in MIME format. --------------030404050700070704050902 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Avi Kivity wrote: > > I see the same issue too now, and am investigating. > The attached patch should fix the issue. It is present in 2.6.25-rc6 only, and not in kvm.git, which is why few people noticed it. -- error compiling committee.c: too many arguments to function --------------030404050700070704050902 Content-Type: text/x-patch; name="fix-kvm-2.6.25-rc6-leak.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="fix-kvm-2.6.25-rc6-leak.patch" diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c index 4ba85d9..e55af12 100644 --- a/arch/x86/kvm/mmu.c +++ b/arch/x86/kvm/mmu.c @@ -1412,7 +1412,7 @@ static void mmu_guess_page_from_pte_write(struct kvm_vcpu *vcpu, gpa_t gpa, up_read(¤t->mm->mmap_sem); vcpu->arch.update_pte.gfn = gfn; - vcpu->arch.update_pte.page = gfn_to_page(vcpu->kvm, gfn); + vcpu->arch.update_pte.page = page; } void kvm_mmu_pte_write(struct kvm_vcpu *vcpu, gpa_t gpa, --------------030404050700070704050902 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ --------------030404050700070704050902 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kvm-devel mailing list kvm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-devel --------------030404050700070704050902--