From: Anthony Liguori <anthony@codemonkey.ws>
To: Avi Kivity <avi@qumranet.com>
Cc: kvm-devel@lists.sourceforge.net,
kvm-ppc-devel <kvm-ppc-devel@lists.sourceforge.net>,
Hollis Blanchard <hollisb@us.ibm.com>
Subject: Re: [PATCH][QEMU] Use a separate device for in-kernel PIT
Date: Sun, 23 Mar 2008 09:06:31 -0500 [thread overview]
Message-ID: <47E663E7.90502@codemonkey.ws> (raw)
In-Reply-To: <47E618B2.9080702@qumranet.com>
Avi Kivity wrote:
> Anthony Liguori wrote:
>
>> Hollis Blanchard wrote:
>>
>>> This patch solves annoying qemu build breakage hitting PowerPC around
>>> struct kvm_pit_state, so that's another vote in favor...
>>>
>>>
>> I have an updated version of the patch but it's breaking the build b/c
>> something fouled up right now with configure. libkvm pulls in
>> linux/kvm.h which wants to pull in linux/compiler.h. We don't ship a
>> linux/compiler.h though so it's pulling from /usr/include/linux which
>> on my system doesn't have a compiler.h.
>>
>> The lack of this header is causing the configure test to fail. I've
>> attached the patch here for you to use and I'll send it out again once
>> I figure out the fix for this linux/compiler.h.
>>
>>
>
> The patch suffers from the same problem as the apic split; the
> save/restore code is needlessly duplicated.
>
The updated patch addresses this problem. I have to fix the
linux/compiler.h issue first though before it can be applied or it will
break the build.
Regards,
Anthony Liguori
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
prev parent reply other threads:[~2008-03-23 14:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-12 17:38 [PATCH][QEMU] Use a separate device for in-kernel PIT Anthony Liguori
2008-03-12 22:04 ` Dor Laor
2008-03-12 22:13 ` Anthony Liguori
2008-03-13 2:20 ` Yang, Sheng
2008-03-16 11:24 ` Avi Kivity
2008-03-16 11:22 ` Avi Kivity
2008-03-21 20:20 ` Hollis Blanchard
2008-03-21 20:24 ` Anthony Liguori
2008-03-23 8:45 ` Avi Kivity
2008-03-23 14:06 ` Anthony Liguori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47E663E7.90502@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=avi@qumranet.com \
--cc=hollisb@us.ibm.com \
--cc=kvm-devel@lists.sourceforge.net \
--cc=kvm-ppc-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox