Re: Qemu-kvm is leaking my memory ???

Avi Kivity
2008-03-24T10:09:31Z

Zdenek Kabelac wrote:
> 2008/3/23, Avi Kivity <avi@qumranet.com>:
>
>> Avi Kivity wrote:
>> >
>> > I see the same issue too now, and am investigating.
>> >
>>
>>
>> The attached patch should fix the issue. It is present in 2.6.25-rc6
>> only, and not in kvm.git, which is why few people noticed it.
>>
>>
>
> Hi
>
> Tested - and actually seeing no difference in my case of memory leak.
> Still it looks like over 30M per execution of qemu is lost.
> (tested with fresh 2.6.25-rc6 with your patch)
>
>

Can you double check? 2.6.25-rc6 definitely leaks without, and here it
doesn't with the patch.

> Also now I'd have said that before my dmsetup status loop test case
> was not causing big problems and it was just enough to run another
> dmsetup to unblock the loop - now it's usually leads to some wierd end
> of qemu itself - will explore more....
>
> So it's probably fixing some bug - and exposing another.
>
> As I said before - in my debuger it was looping in page_fault hadler -
> i.e. memory should be paged_in - but as soon as the handler return to
> the code to continue memcopy - new page_fault is invoked and pointer &
> couters are not changed.

I'll add some code to make it possible to enable the mmu tracer in runtime.

--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.